Jira (FACT-2883) Gem-based Facter 4.0.x does not log the facts in debug mode

[Sanjay Tripathi (Jira)]

Sanjay Tripathi created an issue

Facter / FACT-2883 Gem-based Facter 4.0.x does not log the facts in debug mode Issue Type: Bug Assignee: Unassigned Created: 2020/12/01 6:08 PM Priority: Normal Reporter: Sanjay Tripathi Add new os support on litmus modules Before to start, make sure the new platform is provided by vmpooler and it's fully equipped an image with the new os is available from puppet agent team Here you can find a list with all the converted modules to use litmus Step1: Using pdksync, check/update metadata.json, ci-job-configs/jenkii/platform/projects/modules-unified.yaml metadata.json file check for section: operatingsystem_support add new version under the intended operatingsystem and save ci-job-configs/jenkii/platform/projects/modules-unified.yaml check for the module and add new platform under smoke_platforms| pe_platforms (if this platform was released) Step2: Using pdksync, create PR with the changes on modules Step3: Create PR on ci-job-configs Step4: Deploy experimental platform intended module Step5: Run ad-hoc tests using that experimental Step6: Check testing results Step7: If failures, fix them, re-execute all the testing part until they are green Step8: Ask for review/merge check for vmpooler platform pdksync: update metadata.json pdksync: push changes, create commit create PR on ci-job-configs deploy experimental platform intended module run tests through ad-hoc jenkins using that experimental check testing report if failures, fix them, re-execute ad-hoc until they are green review/merge PR Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Sanjay Tripathi (Jira)]

Sanjay Tripathi updated an issue

Facter / FACT-2883 Gem-based Facter 4.0.x does not log the facts in debug mode

Change By: Sanjay Tripathi Priority: Normal Critical

Add Comment

[Sanjay Tripathi (Jira)]

Sanjay Tripathi commented on FACT-2883

Re: Gem-based Facter 4.0.x does not log the facts in debug mode In debug mode, native facter logs the fact and its value - as in the following example: Facter: fact "fqdn" has resolved to "mymachine.mydomain.com". This is very helpful in debugging. But the gem-based facter does not log the value in the debug mode – instead it logs the cryptic messages, like: Facter: User query is: ["fqdn"] Facter: Query is fqdn Checking query tokens fqdn Facter: List of resolvable facts: [#<Facter::SearchedFact:0x00000219b7a0dfc0 @name="fqdn", @fact_class=Facts::Windows::Networking::Fqdn, @filter_tokens=[], @user_query="fqdn", @type=:legacy, @file=nil>] This is not helpful at all. Please change the debug logging to the previous format of logging the value. Also, it would help to avoid the unnecessary clutter, as in the above example of fqdn.

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

Facter / FACT-2883

Gem-based Facter 4.0.x does not log the facts in debug mode

Change By: Bogdan Irimie Sprint: ghost-2.12 Sub-team: ghost Team: Night's Watch

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

Facter / FACT-2883 Gem-based Facter 4.0.x does not log the facts in debug mode

Change By: Bogdan Irimie Story Points: 2

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie assigned an issue to Bogdan Irimie

Facter / FACT-2883 Gem-based Facter 4.0.x does not log the facts in debug mode

Change By: Bogdan Irimie Assignee: Bogdan Irimie

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie commented on FACT-2883

Re: Gem-based Facter 4.0.x does not log the facts in debug mode Hi Sanjay Tripathi, please give https://github.com/puppetlabs/facter/pull/2203/files a try and let me know if the new log suites your needs. A snippet from the new log: [2020-12-02 16:03:27.230497 ] DEBUG Facter::FactManager - fact "os.release" has resolved to: {"full"=>"20.1.0", "major"=>"20", "minor"=>"1"} [2020-12-02 16:03:27.230507 ] DEBUG Facter::FactManager - fact "os.macosx.product" has resolved to: macOS [2020-12-02 16:03:27.230519 ] DEBUG Facter::FactManager - fact "os.macosx.version" has resolved to: {"full"=>"11.0.1", "major"=>"11.0", "minor"=>"1"} [2020-12-02 16:03:27.230528 ] DEBUG Facter::FactManager - fact "os.macosx.build" has resolved to: 20B29 [2020-12-02 16:03:27.230537 ] DEBUG Facter::FactManager - fact "os.name" has resolved to: Darwin [2020-12-02 16:03:27.230546 ] DEBUG Facter::FactManager - fact "os.hardware" has resolved to: x86_64 [2020-12-02 16:03:27.230555 ] DEBUG Facter::FactManager - fact "os.architecture" has resolved to: x86_64 [2020-12-02 16:03:27.230566 ] DEBUG Facter::FactManager - fact "os.family" has resolved to: Darwin [2020-12-02 16:03:27.230574 ] DEBUG Facter::FactManager - fact "kernelversion" has resolved to: 20.1.0 [2020-12-02 16:03:27.230657 ] DEBUG Facter::FactManager - fact "kernelrelease" has resolved to: 20.1.0 [2020-12-02 16:03:27.230677 ] DEBUG Facter::FactManager - fact "processors.isa" has resolved to: i386 [2020-12-02 16:03:27.230690 ] DEBUG Facter::FactManager - fact "processors.physicalcount" has resolved to: 6 [2020-12-02 16:03:27.230700 ] DEBUG Facter::FactManager - fact "processors.speed" has resolved to: 2.20 GHz   Regarding the other debug messages, they are helpful in diagnostic other types of errors and they should remain.

Add Comment

[Sanjay Tripathi (Jira)]

Sanjay Tripathi commented on FACT-2883

Re: Gem-based Facter 4.0.x does not log the facts in debug mode

Yes, the logging would be helpful as shown in the above snippet. Thanks for the prompt response. Can we minimize the other facter-related debug logging to avoid clutter?

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-2883

Gem-based Facter 4.0.x does not log the facts in debug mode

Change By: Josh Cooper Labels: platform_7.1

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie commented on FACT-2883

Re: Gem-based Facter 4.0.x does not log the facts in debug mode Sanjay Tripathi great, glad you like the new debug messages. They should get in the next release https://github.com/puppetlabs/facter/pull/2203  Regarding the other debug messages we don't plan to remove them as they help us debug complex use cases.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-2883

Gem-based Facter 4.0.x does not log the facts in debug mode

Change By: Josh Cooper

Add new os support on litmus modules

*Before to start, make sure the new platform is provided by vmpooler and it's fully equipped* *an image with the new os is available from puppet agent team* [Here|https://confluence.puppetlabs.com/display/ECO/How+to+add+support+for+new+platforms] you can find a list with all the converted modules to use litmus

Step1: Using pdksync, check/update metadata.json, ci-job-configs/jenkii/platform/projects/modules-unified.yaml

*metadata.json file* - check for section: operatingsystem_support - add new version under the intended operatingsystem and save *[ci-job-configs/jenkii/platform/projects/modules-unified.yaml|https://github.com/puppetlabs/ci-job-configs/blob/master/jenkii/platform/projects/modules-unified.yaml]* - check for the module and add new platform under smoke_platforms| pe_platforms (if this platform was released)

Step2: Using pdksync, create PR with the changes on modules

Step3: Create PR on [ci-job-configs|https://github.com/puppetlabs/ci-job-configs/blob/master/jenkii/platform/projects/modules-unified.yaml]

Step4: Deploy experimental platform intended module Step5: Run ad-hoc tests using that experimental Step6: Check testing results Step7: If failures, fix them, re-execute all the testing part until they are green Step8: Ask for review/merge

(-) check for vmpooler platform (-) pdksync: update metadata.json (-) pdksync: push changes, create commit (-) create PR on ci-job-configs (-) deploy experimental platform intended module (-) run tests through ad-hoc jenkins using that experimental (-) check testing report (-) if failures, fix them, re-execute ad-hoc until they are green (-) review/merge PR

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-2883 Gem-based Facter 4.0.x does not log the facts in debug mode Change By: Josh Cooper

In debug mode, native facter logs the fact and its value - as in the following example: Facter: fact "fqdn" has resolved to "mymachine.mydomain.com". This is very helpful in debugging. But the gem-based facter does not log the value in the debug mode – instead it logs the cryptic messages, like: Facter: User query is: ["fqdn"] Facter: Query is fqdn Checking query tokens fqdn Facter: List of resolvable facts: [#<Facter::SearchedFact:0x00000219b7a0dfc0 @name="fqdn", @fact_class=Facts::Windows::Networking::Fqdn, @filter_tokens=[], @user_query="fqdn", @type=:legacy, @file=nil>]

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Facter / FACT-2883 Gem-based Facter 4.0.x does not log the facts in debug mode

Change By: Mihai Buzgau Fix Version/s: FACT 4.0.47

Add Comment