Jira (FACT-2882) Facter 4.0.x on Windows does not return the domain when set in the registry

21 views
Skip to first unread message

Josh Cooper (Jira)

unread,
Jan 5, 2021, 11:42:03 AM1/5/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Facter / Bug FACT-2882
Facter 4.0.x on Windows does not return the domain when set in the registry
Change By: Josh Cooper
Summary: Gem-based Facter 4.0.x on Windows does not return the complete FQDN domain when set in the registry
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Gene Liverman (Jira)

unread,
Jan 5, 2021, 11:46:04 AM1/5/21
to puppe...@googlegroups.com
Gene Liverman updated an issue
Change By: Gene Liverman
Labels: customer0 doc_reviewed platform_7.2

Oana Tanasoiu (Jira)

unread,
Jan 7, 2021, 3:04:04 AM1/7/21
to puppe...@googlegroups.com
Oana Tanasoiu commented on Bug FACT-2882
 
Re: Facter 4.0.x on Windows does not return the domain when set in the registry

Sanjay Tripathi, can you please re-try running facter with the latest code ? 

We think the issue is solved now on: https://github.com/puppetlabs/facter/pull/2245 .

Sanjay Tripathi (Jira)

unread,
Jan 7, 2021, 4:11:02 AM1/7/21
to puppe...@googlegroups.com

Hello Oana,

Sorry, I need clarification about the source files –
I don't have a git environment and on Windows, I am trying to apply theses changes manually in files installed from Facter gem 4.0.47 (which was released on Dec 15) but there's difference in the files:

1) it does not have lib/facter/resolvers/windows/networking.rb  but it has lib/facter/resolvers/windows/networking_resolver.rb , which does have the original code listed in the diff.
2) Not found: facter/facts/windows/networking/fqdn_spec.rb 
2) Not found: facter/resolvers/windows/networking_spec.rb. 

Sorry to ask but can it be possible for you to build a gem with these changes?

Thanks, Sanjay

Gene Liverman (Jira)

unread,
Jan 7, 2021, 9:10:04 AM1/7/21
to puppe...@googlegroups.com

Oana Tanasoiu (Jira)

unread,
Jan 8, 2021, 7:09:04 AM1/8/21
to puppe...@googlegroups.com

Oana Tanasoiu (Jira)

unread,
Jan 8, 2021, 7:11:03 AM1/8/21
to puppe...@googlegroups.com
Oana Tanasoiu commented on Bug FACT-2882
 
Re: Facter 4.0.x on Windows does not return the domain when set in the registry

Sanjay Tripathi I've attached a gem with the latest code to this issue. Could you give it a try and let me know if everything is ok?

Sanjay Tripathi (Jira)

unread,
Jan 8, 2021, 12:53:02 PM1/8/21
to puppe...@googlegroups.com

I have confirmed that using the fix of 4.0.48 gem on Windows, the FQDN is correct:

facter fqdn
Output:
myhost.mydomain.com

Thanks for fixing it. When will Facter 4.0.48 be released?

Oana Tanasoiu (Jira)

unread,
Jan 11, 2021, 4:15:05 AM1/11/21
to puppe...@googlegroups.com

Sanjay Tripathi thank you for confirming the fix. A new release should be available on 20th this month. 

Mihai Buzgau (Jira)

unread,
Jan 14, 2021, 3:05:04 AM1/14/21
to puppe...@googlegroups.com

Valters Jansons (Jira)

unread,
Jan 19, 2021, 8:12:03 AM1/19/21
to puppe...@googlegroups.com
Valters Jansons commented on Bug FACT-2882
 
Re: Facter 4.0.x on Windows does not return the domain when set in the registry

Oana Tanasoiu, doesn't this then introduce a kind of a regression compared to Puppet 6 with Facter 3?

Shortly, in Puppet 6 it prioritized the user-configured (registry) domain name in favor of the network interface domain. Why this matters is that the registry domain key comes from actions such as joining the computer to a domain. In combination of us having various computers where they have a different domain name coming in from DHCP, that we cannot easily remove as of now, the fix provided will result in that regression blocking us from upgrading, unless I am misreading this.

Oana Tanasoiu (Jira)

unread,
Jan 19, 2021, 9:47:03 AM1/19/21
to puppe...@googlegroups.com

Valters Jansons (Jira)

unread,
Jan 19, 2021, 10:46:03 AM1/19/21
to puppe...@googlegroups.com

Oana Tanasoiu, thank you. I filled the ticket details for you and anyone else stumbling upon it there, to detail the case.

Reply all
Reply to author
Forward
0 new messages