Jira (FACT-2873) KDE Neon is not recognized as Ubuntu base distro

19 views
Skip to first unread message

Andreas Roth (Jira)

unread,
Nov 21, 2020, 9:37:05 AM11/21/20
to puppe...@googlegroups.com
Andreas Roth created an issue
 
Facter / Improvement FACT-2873
KDE Neon is not recognized as Ubuntu base distro
Issue Type: Improvement Improvement
Affects Versions: FACT 3.14.1
Assignee: Unassigned
Created: 2020/11/21 6:36 AM
Environment:

/opt/puppetlabs/bin/facter --version
3.14.14 (commit e36657bea27254f003c8fc71d8ef57454db643e2)

 

/etc/os-release:

{{NAME="KDE neon" }}
{{VERSION="5.20" }}
{{ID=neon }}
{{ID_LIKE="ubuntu debian" }}
{{PRETTY_NAME="KDE neon User Edition 5.20" }}
{{VARIANT="User Edition" }}
{{VERSION_ID="20.04" }}
{{HOME_URL="https://neon.kde.org/" }}
{{SUPPORT_URL="https://neon.kde.org/" }}
{{BUG_REPORT_URL="https://bugs.kde.org/" }}
{{LOGO=start-here-kde-neon }}
{{PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy" }}
{{VERSION_CODENAME=focal }}
UBUNTU_CODENAME=focal
Priority: Normal Normal
Reporter: Andreas Roth

I installed puppet using the ubuntu package: puppet-agent   (6.19.1-1focal) on KDE Neon 5.20.3 (https://neon.kde.org/download).

The facter version shipped with puppet does not recognize the KDE Neon as an ubuntu based distro, which results in errors when using some puppet modules like puppetlabs-docker.

Running factor os returns the following:

{{/opt/puppetlabs/bin/facter os }}
{{{ }}
{{  architecture => "amd64", }}
{{  distro => { }}
{{    codename => "focal", }}
{{    description => "KDE neon User Edition 5.20", }}
{{    id => "Neon", }}
{{    release => { }}
{{      full => "bullseye/sid", }}
{{      major => "bullseye/sid" }}
{{    } }}
{{  }, }}
{{  family => "Debian", }}
{{  hardware => "x86_64", }}
{{  name => "Debian", }}
{{  release => { }}
{{    full => "bullseye/sid", }}
{{    major => "bullseye/sid" }}
{{  }, }}
{{  selinux => { }}
{{    enabled => false }}
{{  } }}
}

KDE Neon is in fact based upon Ubuntu focal.

 
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Gheorghe Popescu (Jira)

unread,
Nov 25, 2020, 2:30:03 AM11/25/20
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
Sprint: ready for triage

Bogdan Irimie (Jira)

unread,
Nov 25, 2020, 2:55:03 AM11/25/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sub-team: ghost
Team: Night's Watch

Bogdan Irimie (Jira)

unread,
Nov 25, 2020, 9:17:02 AM11/25/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Story Points: 2

Bogdan Irimie (Jira)

unread,
Nov 25, 2020, 9:17:04 AM11/25/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ready for triage 2

Bogdan Irimie (Jira)

unread,
Nov 25, 2020, 11:09:03 AM11/25/20
to puppe...@googlegroups.com
Bogdan Irimie commented on Improvement FACT-2873
 
Re: KDE Neon is not recognized as Ubuntu base distro

Hi Andreas Roth

I managed to run facter on KDE Neon 5.20.3

bogdan@bogdan-virtualbox:~$ cat /etc/os-release
 
NAME="KDE neon"
 
VERSION="5.20"
 
ID=neon
 
ID_LIKE="ubuntu debian"
 
PRETTY_NAME="KDE neon User Edition 5.20"
 
VARIANT="User Edition"
 
VERSION_ID="20.04"
 
HOME_URL="https://neon.kde.org/"
 
SUPPORT_URL="https://neon.kde.org/"
 
BUG_REPORT_URL="https://bugs.kde.org/"
 
LOGO=start-here-kde-neon
 
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
 
VERSION_CODENAME=focal
 
UBUNTU_CODENAME=focal

the output from Facter 3 (the default facter in puppet 6.19) is

root@bogdan-virtualbox:~# facter --version
 
3.14.14 (commit e36657bea27254f003c8fc71d8ef57454db643e2)
 
root@bogdan-virtualbox:~# facter os
 
{
 
  architecture => "amd64",
 
  distro => {
 
    codename => "focal",
 
    description => "KDE neon User Edition 5.20",
 
    id => "Neon",
 
    release => {
 
      full => "bullseye/sid",
 
      major => "bullseye/sid"
 
    }
 
  },
 
  family => "Debian",
 
  hardware => "x86_64",
 
  name => "Debian",
 
  release => {
 
    full => "bullseye/sid",
 
    major => "bullseye/sid"
 
  },
 
  selinux => {
 
    enabled => false
 
  }
 
}

the output for Facter 4 (the default facter starting with Puppet 7) is:

root@bogdan-virtualbox:~# /opt/puppetlabs/puppet/bin/facter-ng os
 
{
 
  architecture => "amd64",
 
  distro => {
 
    codename => "focal",
 
    description => "KDE neon User Edition 5.20",
 
    id => "Neon",
 
    release => {
 
      full => "20.04",
 
      major => "20.04"
 
    }
 
  },
 
  family => "Ubuntu debian",
 
  hardware => "x86_64",
 
  name => "KDE",
 
  release => {
 
    full => "20.04",
 
    major => "20.04"
 
  },
 
  selinux => {
 
    enabled => false
 
  }
 
}

Can you please indicate what fact is causing the issue? Is it the `family` fact?

Andreas Roth (Jira)

unread,
Nov 25, 2020, 11:30:03 AM11/25/20
to puppe...@googlegroups.com
Andreas Roth commented on Improvement FACT-2873

In the docker module:

https://github.com/puppetlabs/puppetlabs-docker/blob/main/manifests/params.pp

The family (Debian; correct) is used first, then the "name" is used as a secondary selector. For KDE Neon the fact "name" is set to "Debian" which causes the debian packages to be used and this results in errors down the line.

I would expect the name to be returned as either "Neon" or as "Ubuntu". This way the module can install the ubuntu packages or a "new rule" for "neon" needs to be added. At the moment the module cannot determine that KDE neon is installed/used.

Bogdan Irimie (Jira)

unread,
Dec 2, 2020, 2:39:04 AM12/2/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ghost-2.12 , ready for triage 2

Bogdan Irimie (Jira)

unread,
Dec 16, 2020, 2:33:15 PM12/16/20
to puppe...@googlegroups.com
Bogdan Irimie commented on Improvement FACT-2873
 
Re: KDE Neon is not recognized as Ubuntu base distro

Hi Andreas Roth

 

Thank you for filing this issue. We agree it is likely an improvement, but due to other issues demanding precedence, we don’t anticipate being able to address this any time soon. If you are interested in submitting a patch to the repository for this project at https://github.com/puppetlabs/facter, please open a pull request.

If you would like to contribute I encourage you to migrate to Puppet 7. Puppet 7 uses Facter 4. Currently the name detected by Facter 4 is KDE, but the family contains multiple strings (will be addressed in FACT-2902). A good place to start would be https://github.com/puppetlabs/facter/blob/main/lib/facter/resolvers/os_release_resolver.rb and https://github.com/puppetlabs/facter/blob/main/lib/facter/facts/linux/os/family.rb

Bogdan Irimie (Jira)

unread,
Jun 30, 2021, 2:26:01 AM6/30/21
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sub-team: ghost
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Ciprian Badescu (Jira)

unread,
Oct 20, 2021, 4:56:03 AM10/20/21
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
Change By: Ciprian Badescu
Sprint: ghost-2.12 , ready for triage 2
Reply all
Reply to author
Forward
0 new messages