Jira (FACT-2859) [regression] External facts are loaded when using puppet lookup for a different node

18 views
Skip to first unread message

Josh Cooper (Jira)

unread,
Nov 13, 2020, 6:42:03 PM11/13/20
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Facter / Bug FACT-2859
[regression] External facts are loaded when using puppet lookup for a different node
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2020/11/13 3:41 PM
Priority: Normal Normal
Reporter: Josh Cooper

FACT-2666 added a Facter.load_external method which puppet checks to enable/disable external fact loading. The method was added to facter 3, but doesn't exist in facter 4, so puppet doesn't disable external fact loading.

# rpm -qa | grep puppet
 
puppet-agent-7.0.0-1.el8.x86_64
 
# cat /opt/puppetlabs/facter/facts.d/slow.sh
 
#!/bin/sh
 
 
 
>&2 echo "this is slow"
 
# chmod u+x /opt/puppetlabs/facter/facts.d/slow.sh
 
# puppet lookup --node notme key
 
Warning: Facter: Command /opt/puppetlabs/facter/facts.d/slow.sh completed with the following stderr message: this is slow
 
Warning: Facter: Command /opt/puppetlabs/facter/facts.d/slow.sh completed with the following stderr message: this is slow

This wasn't noticed in tests, because we don't verify partial doubles:
https://github.com/puppetlabs/puppet/blob/29a737f765d94bfb30bdb3d89c55e54edfcc16b9/spec/integration/application/lookup_spec.rb#L101-L102
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Mihai Buzgau (Jira)

unread,
Nov 17, 2020, 2:09:03 AM11/17/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: ready for triage

Mihai Buzgau (Jira)

unread,
Nov 17, 2020, 2:09:03 AM11/17/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sub-team: ghost

Mihai Buzgau (Jira)

unread,
Nov 17, 2020, 2:09:03 AM11/17/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Team: Night's Watch

Bogdan Irimie (Jira)

unread,
Nov 18, 2020, 9:10:02 AM11/18/20
to puppe...@googlegroups.com

Bogdan Irimie (Jira)

unread,
Nov 18, 2020, 9:11:02 AM11/18/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
 
Change By: Bogdan Irimie
Story Points: 2

Bogdan Irimie (Jira)

unread,
Nov 18, 2020, 9:11:03 AM11/18/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ready for triage ghost 25.11

Oana Tanasoiu (Jira)

unread,
Nov 19, 2020, 2:27:02 AM11/19/20
to puppe...@googlegroups.com
Oana Tanasoiu assigned an issue to Oana Tanasoiu
Change By: Oana Tanasoiu
Assignee: Oana Tanasoiu

Bogdan Irimie (Jira)

unread,
Nov 25, 2020, 9:04:05 AM11/25/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ghost 25.11 , ready for triage 2

Bogdan Irimie (Jira)

unread,
Dec 2, 2020, 2:39:03 AM12/2/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ghost 25.11, ghost-2.12 , ready for triage 2

Bogdan Irimie (Jira)

unread,
Dec 2, 2020, 2:53:03 AM12/2/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ghost 25.11, ghost-2.12, ready for triage ghost- 2 .12

Josh Cooper (Jira)

unread,
Dec 2, 2020, 2:14:03 PM12/2/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Affects Version/s: FACT 4.0.46

Josh Cooper (Jira)

unread,
Dec 2, 2020, 2:14:04 PM12/2/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Labels: platform_7.1

Mihai Buzgau (Jira)

unread,
Dec 9, 2020, 7:23:04 AM12/9/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Fix Version/s: FACT 4.0.47
Reply all
Reply to author
Forward
0 new messages