Jira (PDB-4942) Don't open two connections for every query

[Rob Browning (Jira)]

Rob Browning created an issue

PuppetDB / PDB-4942 Don't open two connections for every query Issue Type: Bug Assignee: Unassigned Created: 2020/10/22 12:08 PM Fix Versions: PDB 7.0.0 Priority: Normal Reporter: Rob Browning Zak noticed that we've unintentionally nested with-db-connection forms in the query path.  We should fix that, and ideally, if we can, in the upcoming X release (7), since it may have broader effects, i.e. suddenly freeing up a bunch of connections may well substantially increase the database load that pdb can generate, if say the hikari pool size isn't proportionally decreased. Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Rob Browning (Jira)]

Rob Browning updated an issue

PuppetDB / PDB-4942 Don't open two connections for every query

Change By: Rob Browning

Zak noticed that we've unintentionally nested with-db-connection forms in the query path.  We should fix that, and ideally, if we can, in the upcoming X release (7), since it may have broader effects, i.e. suddenly freeing up a bunch of connections may well substantially increase the database load that pdb can generate, if say the hikari pool size isn't proportionally decreased.

But overall, this may be a notable improvement with respect to postgresql since right now we must be overprovisioning pg connections to compensate.

Add Comment