Jira (PUP-10714) remove "master_used" report parameter in puppet 7

0 views
Skip to first unread message

Ciprian Badescu (Jira)

unread,
Oct 14, 2020, 2:03:03 AM10/14/20
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
 
Puppet / Task PUP-10714
remove "master_used" report parameter in puppet 7
Change By: Ciprian Badescu
Summary: delete remove "master_used" report parameter in puppet 7
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Josh Cooper (Jira)

unread,
Oct 14, 2020, 1:31:03 PM10/14/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Oct 14, 2020, 1:31:03 PM10/14/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Change By: Josh Cooper
Fix Version/s: PUP 7.0.0

Josh Cooper (Jira)

unread,
Oct 14, 2020, 1:31:03 PM10/14/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Oct 16, 2020, 1:26:05 PM10/16/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Oct 23, 2020, 2:45:03 PM10/23/20
to puppe...@googlegroups.com
Josh Cooper commented on Task PUP-10714
 
Re: remove "master_used" report parameter in puppet 7

Passed CI in d0523b273c80ddda0a5dc9a70c3d7b735e0fe5c3

Ciprian Badescu (Jira)

unread,
Oct 26, 2020, 6:26:03 AM10/26/20
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
 
Change By: Ciprian Badescu
Release Notes: Deprecation

Ciprian Badescu (Jira)

unread,
Oct 26, 2020, 6:27:03 AM10/26/20
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
Change By: Ciprian Badescu
Release Notes Summary: remove `master_used` from puppet 7 report since we already have `server_used` with the same information and there is no usage of `master_used` in our products

Claire Cadman (Jira)

unread,
Nov 9, 2020, 9:52:03 AM11/9/20
to puppe...@googlegroups.com
Claire Cadman updated an issue
Change By: Claire Cadman
Labels: doc_reviewed platform_7

Scott Cyprus (Jira)

unread,
May 14, 2021, 5:06:02 PM5/14/21
to puppe...@googlegroups.com
Scott Cyprus commented on Task PUP-10714
 
Re: remove "master_used" report parameter in puppet 7

So you decided to break people's builds to arbitrarily change the name of a previously working variable?

The new "server_used" terminology was marked as resolved on 2020/10/13 (PUP-10672), and then the old terminology "master_used" was not only deprecated but completely removed on 2020/10/26. Do you see how bad this is? Do you folks care at all anymore?

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Scott Cyprus (Jira)

unread,
May 14, 2021, 5:06:04 PM5/14/21
to puppe...@googlegroups.com
Scott Cyprus updated an issue
 
Change By: Scott Cyprus
Comment:
So you decided to break people's builds to arbitrarily change the name of a previously working variable?

The new "server_used" terminology was marked as resolved on 2020/10/13 (PUP-10672), and then the old terminology "master_used" was not only deprecated but completely removed on 2020/10/26. Do you see how bad this is? Do you folks care at all anymore?

Scott Cyprus (Jira)

unread,
May 14, 2021, 5:20:04 PM5/14/21
to puppe...@googlegroups.com
Scott Cyprus commented on Task PUP-10714
 
Re: remove "master_used" report parameter in puppet 7

The new terminology "server_used" was marked as resolved on 2020/10/13, and the old terminology "master_used" was completely removed (without deprecation notice) on 2020/10/26.

It was mention that you don't think the variable is used anywhere in the product, but what about the humans who read documentation that's still on the internet who do expect that variable to work (maybe somebody wrote a blog post because it actually did work for 13 days)? Do you see how things like this erode trust in the puppet ecosystem?

Josh Cooper (Jira)

unread,
May 14, 2021, 7:28:02 PM5/14/21
to puppe...@googlegroups.com
Josh Cooper commented on Task PUP-10714

Scott Cyprus The old terminology was deprecated in the 6.x release and removed in 7.0. Also the report_format field in the report schema was updated, so any automation trying to parse the report would know that the master_used field had been removed, see https://github.com/puppetlabs/puppet/commit/ac248dd5b66e7ac1701316b149e0c47af26ab64b.

Scott Cyprus (Jira)

unread,
May 17, 2021, 9:55:04 AM5/17/21
to puppe...@googlegroups.com
Scott Cyprus commented on Task PUP-10714

Josh Cooper By only putting the deprecation notice in the release documentation (and not within a warning emitted during puppet runs), it forces build maintainers to look in two places instead of one. Is it fair to expect deprecation notices to be displayed as warnings during puppet runs, as opposed to finding out that it just doesn't work anymore and having to dig through release documentation to validate that?

Reply all
Reply to author
Forward
0 new messages