Jira (PUP-10685) Clean up ext/ directory

Gabriel Nagy (Jira)

unread,

Oct 5, 2020, 4:09:03 AM10/5/20

to puppe...@googlegroups.com

Gabriel Nagy created an issue

Puppet /

PUP-10685

Clean up ext/ directory

Issue Type:	Improvement
Assignee:	Unassigned
Created:	2020/10/05 1:08 AM
Priority:	Normal
Reporter:	Gabriel Nagy

There are some scripts in the ext/ directory left over from the ruby puppet master (webrick & passenger) and can be removed.

On a first look, these can be removed:

https://github.com/puppetlabs/puppet/tree/main/ext/debian (stuff here is really old, doubt it's still being used)
https://github.com/puppetlabs/puppet/tree/main/ext/freebsd (puppetd and puppetmasterd are no longer a thing)
https://github.com/puppetlabs/puppet/tree/main/ext/gentoo (these are also old, and gentoo seems to vendor their own config files at https://gitweb.gentoo.org/repo/gentoo.git/tree/app-admin/puppet/files)
https://github.com/puppetlabs/puppet/tree/main/ext/ips (not sure about this one)
https://github.com/puppetlabs/puppet/tree/main/ext/ldap (VERY old)
https://github.com/puppetlabs/puppet/tree/main/ext/osx
- found references to the preflight and postflight ERBs in https://github.com/puppetlabs/packaging/blob/1.0.x/tasks/apple.rake but it appears it's been superseded by https://github.com/puppetlabs/vanagon/blob/master/lib/vanagon/platform/osx.rb (not 100% sure though, but this is what our Jenkins pipelines are using)
https://github.com/puppetlabs/puppet/tree/main/ext/redhat (more old stuff)
https://github.com/puppetlabs/puppet/tree/main/ext/regexp_nodes (no idea about this one)
https://github.com/puppetlabs/puppet/tree/main/ext/solaris/smf (puppetd and puppetmasterd files and references can be removed)
https://github.com/puppetlabs/puppet/tree/main/ext/suse (some of this may be used on SLES 11?)
https://github.com/puppetlabs/puppet/blob/main/ext/dbfix.sql (probably not used anymore)

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

Mihai Buzgau (Jira)

unread,

Oct 7, 2020, 3:43:03 AM10/7/20

to puppe...@googlegroups.com

Mihai Buzgau updated an issue

Puppet /

PUP-10685

Clean up ext/ directory

Change By:	Mihai Buzgau
Story Points:	1

Add Comment

Bogdan Irimie (Jira)

unread,

Nov 5, 2020, 3:51:04 AM11/5/20

to puppe...@googlegroups.com

Bogdan Irimie updated an issue

Puppet /

PUP-10685

Clean up ext/ directory

Change By:	Bogdan Irimie
Sprint:

Add Comment

Bogdan Irimie (Jira)

unread,

Nov 5, 2020, 3:52:05 AM11/5/20

to puppe...@googlegroups.com

Bogdan Irimie updated an issue

Puppet /

PUP-10685

Clean up ext/ directory

Change By:	Bogdan Irimie
Sprint:	ready for triage

Add Comment

Josh Cooper (Jira)

unread,

Nov 5, 2020, 9:25:03 PM11/5/20

to puppe...@googlegroups.com

Josh Cooper commented on

PUP-10685

Re: Clean up ext/ directory

Your comments match what I'd expect. I think IPS was used for Solaris? The regexp_nodes script was a fully working external node classifier, so given a hostname return a YAML hash containing classes, parameters, etc to include for that node during compilation. See https://web.archive.org/web/20140325101445/http://projects.puppetlabs.com/issues/2724 It probably works as the API hasn't really changed, but the file probably belongs in `examples/enc`.