Jira (PUP-10666) puppet-agent config option require message for disable

12 views
Skip to first unread message

Pat Riehecky (Jira)

unread,
Sep 14, 2020, 10:15:06 AM9/14/20
to puppe...@googlegroups.com
Pat Riehecky created an issue
 
Puppet / New Feature PUP-10666
puppet-agent config option require message for disable
Issue Type: New Feature New Feature
Assignee: Unassigned
Created: 2020/09/14 7:14 AM
Priority: Normal Normal
Reporter: Pat Riehecky

Hello,

 

Could a config option be added for the puppet agent to require a message when running `puppet agent --disable`?  For larger sites with multiple admins, it would be helpful to have a way to force this best practice.  I don't expect it to stop `puppet agent --disable ' '` but in that instance the admin knows they are leaving a useless message against the policy.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Josh Cooper (Jira)

unread,
Nov 17, 2020, 3:57:03 PM11/17/20
to puppe...@googlegroups.com
Josh Cooper commented on New Feature PUP-10666
 
Re: puppet-agent config option require message for disable

It'd be fairly easy to add a puppet setting, something like agent_disabled_required_message = true|false to complement agent_disabled_lockfile. If the setting was true and you ran puppet agent --disable then have the agent print an error that a message is required and error, leaving the agent in whatever state it was in previously.

Mihai Buzgau (Jira)

unread,
Dec 1, 2020, 10:44:03 AM12/1/20
to puppe...@googlegroups.com

Mihai Buzgau (Jira)

unread,
Dec 1, 2020, 10:54:03 AM12/1/20
to puppe...@googlegroups.com

Mihai Buzgau (Jira)

unread,
Dec 1, 2020, 10:54:04 AM12/1/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Labels: beginner help-wanted

Josh Cooper (Jira)

unread,
Dec 1, 2020, 10:55:03 AM12/1/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Labels: beginner help-wanted help_wanted

Mihai Buzgau (Jira)

unread,
Dec 1, 2020, 11:04:05 AM12/1/20
to puppe...@googlegroups.com
Mihai Buzgau commented on New Feature PUP-10666
 
Re: puppet-agent config option require message for disable

Hi Pat Riehecky

Thank you for filing this issue. We agree it is likely an improvement, but due to other issues demanding precedence, we don’t anticipate being able to address this any time soon. If you are interested in submitting a patch to the repository for this project at https://github.com/puppetlabs/puppet, please open a pull request.

Reply all
Reply to author
Forward
0 new messages