Jira (PUP-10648) puppet 6 agent doesn't honor usecacheonfailure setting when using server_list

1 view
Skip to first unread message

Josh Cooper (Jira)

unread,
Aug 27, 2020, 7:46:03 PM8/27/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Puppet / Bug PUP-10648
puppet 6 agent doesn't honor usecacheonfailure setting when using server_list
Change By: Josh Cooper
Summary: puppet 6 agent doesn't honor usecacheonfailure setting when using server_list
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Josh Cooper (Jira)

unread,
Aug 27, 2020, 7:47:03 PM8/27/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Coremunity

Josh Cooper (Jira)

unread,
Sep 9, 2020, 10:24:04 PM9/9/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 6.19.0

Josh Cooper (Jira)

unread,
Sep 9, 2020, 10:43:03 PM9/9/20
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-10648
 
Re: puppet 6 agent doesn't honor usecacheonfailure setting when using server_list

This was broken in:

commit 2e24fb76c84c8604da3606967f69a0a29b85f265
 
Author: Melissa Stone <mel...@puppet.com>
 
Date:   Fri Feb 15 15:39:58 2019 -0800
 
 
 
    (PUP-9076) Do not push nil on server context
 
 
 
    and fail if none of the servers in `server_list` are reachable
 
 
 
:040000 040000 85e374f3c6c205f0d591f57e8d5a52ab04bc116c 5cbdef33008c604f599eafa8337adcdbbb15a42e M	lib
 
:040000 040000 16c9a771f8f9f2a5f0cd56bd9c6e2a15e8516cac 0491538df3b80e5f96bdf00b36f17fd3a41a4d7f M	spec

Previously if we failed to connect to a valid server, we pushed [nil, nil] on the context and then tried to connect to ":8140" for the node, catalog, etc requests, which of course failed. We then failed back to the cached catalog.

After this commit, we raise if we can't resolve a valid server, never giving the agent a chance to use its cached catalog.

Josh Cooper (Jira)

unread,
Sep 14, 2020, 9:29:03 PM9/14/20
to puppe...@googlegroups.com
Josh Cooper assigned an issue to Josh Cooper
 
Change By: Josh Cooper
Assignee: Josh Cooper

Josh Cooper (Jira)

unread,
Sep 14, 2020, 9:29:03 PM9/14/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Platform Core KANBAN

Josh Cooper (Jira)

unread,
Sep 15, 2020, 6:21:04 PM9/15/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Coremunity Night's Watch

Josh Cooper (Jira)

unread,
Sep 15, 2020, 6:21:04 PM9/15/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Platform Core KANBAN

Mihai Buzgau (Jira)

unread,
Sep 16, 2020, 1:54:04 AM9/16/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2020-09-30

Mihai Buzgau (Jira)

unread,
Sep 16, 2020, 5:15:04 AM9/16/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW PR - 2020-09-30 Triage

Mihai Buzgau (Jira)

unread,
Sep 30, 2020, 5:46:04 AM9/30/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: PR NW - Triage 2020-10-14

Mihai Buzgau (Jira)

unread,
Sep 30, 2020, 5:46:06 AM9/30/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Story Points: 2

Ciprian Badescu (Jira)

unread,
Oct 1, 2020, 5:29:03 AM10/1/20
to puppe...@googlegroups.com
Ciprian Badescu assigned an issue to Ciprian Badescu
Change By: Ciprian Badescu
Assignee: Josh Cooper Ciprian Badescu

Mihai Buzgau (Jira)

unread,
Nov 5, 2020, 4:04:02 AM11/5/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Fix Version/s: PUP 7.0.0

Claire Cadman (Jira)

unread,
Nov 9, 2020, 11:43:04 AM11/9/20
to puppe...@googlegroups.com
Claire Cadman updated an issue
Change By: Claire Cadman
Labels: doc_reviewed
Reply all
Reply to author
Forward
0 new messages