Jira (PUP-10613) Puppet::Util.uri_encode discards '='

[Josh Cooper (Jira)]

Josh Cooper created an issue

Puppet / PUP-10613 Puppet::Util.uri_encode discards '=' Issue Type: Bug Assignee: Unassigned Created: 2020/08/07 4:49 PM Priority: Normal Reporter: Josh Cooper The uri_encode method assumes '=' characters are key/value delimiters in the query string, which is a problem if the query string contains a base64 encoded signature with trailing padding characters like the following. Note both URI and Addressable preserve the trailing '=' but puppet does not: irb(main):014:0> str = "http://a.com?sig=JaZhcqxT4akJcOwUdUGrQB2m1geUoh89iL8WMag8a8c=" => "http://a.com?sig=JaZhcqxT4akJcOwUdUGrQB2m1geUoh89iL8WMag8a8c=" irb(main):015:0> Puppet::Util.uri_encode(str) => "http://a.com?sig=JaZhcqxT4akJcOwUdUGrQB2m1geUoh89iL8WMag8a8c" irb(main):016:0> URI.encode(str) => "http://a.com?sig=JaZhcqxT4akJcOwUdUGrQB2m1geUoh89iL8WMag8a8c=" irb(main):017:0> Addressable::URI.encode("http://a.com/sig=JaZhcqxT4akJcOwUdUGrQB2m1geUoh89iL8WMag8a8c=") => "http://a.com/sig=JaZhcqxT4akJcOwUdUGrQB2m1geUoh89iL8WMag8a8c=" See also PUP-10603 Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10613 Puppet::Util.uri_encode discards '='

Change By: Josh Cooper Team: Coremunity

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10613 Puppet::Util.uri_encode discards '='

Change By: Josh Cooper Epic Link: PUP-10649

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10613 Puppet::Util.uri_encode discards '='

Change By: Josh Cooper Sprint: Coremunity Grooming

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10613 Puppet::Util.uri_encode discards '='

Change By: Josh Cooper Labels: platform_7

Add Comment

[Josh Cooper (Jira)]

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10613 Puppet::Util.uri_encode discards '='

Change By: Josh Cooper Sprint: Coremunity Grooming

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)