We were coming to the same conclusion ourselves after a chat earlier Josh Cooper. If you're also saying this is quite specific to handle the different registry value types, then we've narrowed the impact further, which pushes more in the direction of applying the fix you did to puppetlabs-registry. A quick check shows 671 Windows modules on the Forge - I've pinged Ben Ford about any way we could potentially audit those modules to look for any calls to wide_string. I would suspect the hits to be very low, if not 0, but do you think this is a worthwhile endeavour? FWIW, I did a quick check through Voxpupuli's Github repo for "wide_string" and got no results back. I'm running tests against your PR locally. I created a PR to kick off the CI tests, but there was a Rubocop violation causing it to bomb out early. Would you mind approving and merging this PR to yours when you get a chance? https://github.com/joshcooper/puppetlabs-registry/pull/2 Thanks again for your help! |