Jira (PUP-10601) Only create pcore resource type loaders for compilation

7 views
Skip to first unread message

Josh Cooper (Jira)

unread,
Jul 27, 2020, 5:15:03 PM7/27/20
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Task PUP-10601
Only create pcore resource type loaders for compilation
Issue Type: Task Task
Assignee: Unassigned
Created: 2020/07/27 2:14 PM
Fix Versions: PUP 7.0.0
Priority: Normal Normal
Reporter: Josh Cooper
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Josh Cooper (Jira)

unread,
Jul 27, 2020, 5:26:03 PM7/27/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Puppet pcore resource type definitions are generated using {{puppet generate types}} and ensure resource types are isolated in a single environment. This is needed by the compiler as it needs to compile catalogs on behalf of agents in multiple environments. However, the pops loaders will by default include the pcore resource type loader which can lead to issues like PUP-9602. It also means pcore resource types could be loaded by another application unexpectedly.

For puppet 7, change the default behavior so that pcore resource types are not automatically loaded, and modify puppetserver to opt-into the behavior. Need to research {{puppet script}}.

Josh Cooper (Jira)

unread,
Jul 28, 2020, 7:54:02 PM7/28/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Puppet pcore resource type definitions are generated using {{puppet generate types}} and ensure resource types are isolated in a single environment. This is needed by the compiler as it needs to compile catalogs on behalf of agents in multiple environments. However, the pops loaders will by default include the pcore resource type loader which can lead to issues like PUP-9602. It also means pcore resource types could be loaded by another application unexpectedly.

For puppet 7, change the default behavior so that pcore resource types are not automatically loaded, and modify puppetserver to opt-into the behavior. Need to research {{puppet script}}.


We may not want to change the default due to bolt and orchestrator

Josh Cooper (Jira)

unread,
Aug 27, 2020, 3:44:03 PM8/27/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Oct 29, 2020, 7:27:03 PM10/29/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 7.0.0

Josh Cooper (Jira)

unread,
Oct 29, 2020, 7:27:03 PM10/29/20
to puppe...@googlegroups.com
Josh Cooper commented on Task PUP-10601
 
Re: Only create pcore resource type loaders for compilation

Changing the default behavior would need to be coordinated with puppetserver as well as external tools that interact with the compiler like catalog-diff and puppet-strings. So I'm going to close this as won't fix.

Reply all
Reply to author
Forward
0 new messages