Jira (PUP-10598) Change default value of ignore_plugin_errors to false

24 views
Skip to first unread message

Josh Cooper (Jira)

unread,
Aug 20, 2020, 4:05:03 PM8/20/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Puppet / Task PUP-10598
Change default value of ignore_plugin_errors to false
Change By: Josh Cooper
Summary: Remove setting Change default value of ignore_plugin_errors to ignore pluginsync errors false
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Josh Cooper (Jira)

unread,
Aug 20, 2020, 4:05:03 PM8/20/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
PUP-1763 added a setting to allow the agent to stop the run if pluginsync fails. In puppet 7, the setting should be removed changed so the agent should always fail the run if pluginsync fails.

Mihai Buzgau (Jira)

unread,
Aug 26, 2020, 3:43:04 AM8/26/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2020-09-16

Mihai Buzgau (Jira)

unread,
Aug 26, 2020, 3:43:04 AM8/26/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Story Points: 1

Mihai Buzgau (Jira)

unread,
Aug 26, 2020, 4:09:03 AM8/26/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2020-09- 16 01

Ciprian Badescu (Jira)

unread,
Aug 31, 2020, 6:19:03 AM8/31/20
to puppe...@googlegroups.com
Ciprian Badescu assigned an issue to Ciprian Badescu
Change By: Ciprian Badescu
Assignee: Ciprian Badescu

Josh Cooper (Jira)

unread,
Sep 1, 2020, 12:08:03 PM9/1/20
to puppe...@googlegroups.com

Ciprian Badescu (Jira)

unread,
Sep 2, 2020, 2:50:03 AM9/2/20
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
 
Change By: Ciprian Badescu
Release Notes: Enhancement
Release Notes Summary: change default value of ignore_plugin_errors to false.

If ignore_plugin_errors is true(default value before this commit),
puppet agents can fail to pluginsync and will be missing facts/types/providers that may be needed to request and apply the catalog.

For example, missing custom/external facts can change which classes are included in the catalog or cause compilation failures if the manifests references the missing fact.

Mihai Buzgau (Jira)

unread,
Sep 2, 2020, 5:19:04 AM9/2/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2020-09-01 , NW - 2020-09-16

Josh Cooper (Jira)

unread,
Sep 8, 2020, 8:06:03 PM9/8/20
to puppe...@googlegroups.com
Josh Cooper commented on Task PUP-10598
 
Re: Change default value of ignore_plugin_errors to false

Sorry Ciprian Badescu I had to revert this change as described in https://github.com/puppetlabs/puppet/pull/8321#issue-482374474. I didn't account for using cached catalogs when I originally implemented PUP-1763. My bad. Could you look into fixing PUP-1763 in 5.5.x, so that if pluginsync fails and ignore_plugin_errors==false, then we still fall back to the cached catalog (if we're allowed to based on {{usecacheonfailure)? Then we can re-revert your change for this ticket?

Mihai Buzgau (Jira)

unread,
Sep 16, 2020, 5:57:04 AM9/16/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2020-09-01, NW - 2020-09-16 , NW - 2020-09-30

Mihai Buzgau (Jira)

unread,
Sep 30, 2020, 3:50:04 AM9/30/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2020-09-01, NW - 2020-09-16, NW - 2020-09-30 , NW - 2020-10-14

Josh Cooper (Jira)

unread,
Oct 1, 2020, 10:36:03 PM10/1/20
to puppe...@googlegroups.com
Josh Cooper commented on Task PUP-10598

Claire Cadman (Jira)

unread,
Nov 9, 2020, 11:48:03 AM11/9/20
to puppe...@googlegroups.com
Claire Cadman updated an issue
 
Change By: Claire Cadman
Labels: doc_reviewed platform_7
Reply all
Reply to author
Forward
0 new messages