Jira (FACT-2717) Block external facts

18 views
Skip to first unread message

Bogdan Irimie (Jira)

unread,
Jul 22, 2020, 5:00:03 AM7/22/20
to puppe...@googlegroups.com
Bogdan Irimie created an issue
 
Facter / Task FACT-2717
Block external facts
Issue Type: Task Task
Assignee: Unassigned
Created: 2020/07/22 1:59 AM
Priority: Normal Normal
Reporter: Bogdan Irimie

Currently we cannot block external facts. A mechanism similar to the one for internal facts does not work, because we already resolved the external facts at this stage, negating any performance effect of blocking.

We should implement blocking in directory_loader. Before calling the cache manager, we could block the facts (in this case they are represented by file names)
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Bogdan Irimie (Jira)

unread,
Jul 22, 2020, 9:25:03 AM7/22/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ready for triage ghost-29.07

Bogdan Irimie (Jira)

unread,
Jul 22, 2020, 9:25:03 AM7/22/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Story Points: 3

Bogdan Irimie (Jira)

unread,
Jul 22, 2020, 9:27:03 AM7/22/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Currently we cannot block external facts. A mechanism similar to the one for [internal facts|https://github.com/puppetlabs/facter/blob/d3b48a2b415e2b9831758655ce7be3cb16c90364/lib/facter/framework/core/fact_loaders/fact_loader.rb#L43] does not work, because we already resolved the external facts at this stage,  negating any performance effect of blocking.

We should implement blocking in [directory_loader|https://github.com/puppetlabs/facter/blob/d3b48a2b415e2b9831758655ce7be3cb16c90364/lib/facter/custom_facts/util/directory_loader.rb#L54]. Before calling the [cache manager|https://github.com/puppetlabs/facter/blob/d3b48a2b415e2b9831758655ce7be3cb16c90364/lib/facter/custom_facts/util/directory_loader.rb#L69], we could block the facts (in this case they are represented by file names)


Add integration test.

Florin Dragos (Jira)

unread,
Jul 27, 2020, 2:58:03 AM7/27/20
to puppe...@googlegroups.com
Florin Dragos assigned an issue to Florin Dragos
Change By: Florin Dragos
Assignee: Florin Dragos

Bogdan Irimie (Jira)

unread,
Jul 29, 2020, 9:03:10 AM7/29/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ghost-29.07 , ready for triage 2

Bogdan Irimie (Jira)

unread,
Nov 5, 2020, 8:32:03 AM11/5/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Release Notes: Not Needed Enhancement
Release Notes Summary: Allow users to block external facts. The blocking of external facts is a little different from the blocking of core and custom facts because we need to specify the name of the file from which external facts are loaded. Basically we can block files, not facts.

In order to block external facts, we need to specify the name of the file in the `blocklist` in `facter.conf`

Mihai Buzgau (Jira)

unread,
Nov 5, 2020, 9:38:03 AM11/5/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Fix Version/s: FACT 4.0.45

Claire Cadman (Jira)

unread,
Nov 10, 2020, 5:56:03 AM11/10/20
to puppe...@googlegroups.com
Claire Cadman updated an issue
Change By: Claire Cadman
Labels: doc_reviewed
Reply all
Reply to author
Forward
0 new messages