Jira (PUP-10586) Regression: Puppet::Util.default_env method removed in 5.5.21 and 6.17.0

0 views
Skip to first unread message

Josh Cooper (Jira)

unread,
Jul 15, 2020, 1:16:03 PM7/15/20
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Bug PUP-10586
Regression: Puppet::Util.default_env method removed in 5.5.21 and 6.17.0
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2020/07/15 10:15 AM
Priority: Normal Normal
Reporter: Josh Cooper

Commit https://github.com/puppetlabs/puppet/commit/94df3c1a3992d89b2d7d5db8a70373c135bdd86b unintentionally removed the Puppet::Util.default_env method in 5.5.21 and 6.17.0, causing the following error when testing puppet modules using rspec-puppet:

 Failure/Error: require 'puppetlabs_spec_helper/module_spec_helper'
 NameError:
   undefined local variable or method `default_env' for Puppet::Util:Module
 # ./vendor/bundle/ruby/2.5.0/gems/rspec-puppet-2.7.8/lib/rspec-puppet/monkey_patches.rb:139:in `get_env'
 # ./vendor/bundle/ruby/2.5.0/gems/puppet-6.17.0/lib/puppet/node/environment.rb:501:in `extralibs'
 # ./vendor/bundle/ruby/2.5.0/gems/puppet-6.17.0/lib/puppet/node/environment.rb:76:in `initialize'
 # ./vendor/bundle/ruby/2.5.0/gems/puppet-6.17.0/lib/puppet/node/environment.rb:43:in `new'
 # ./vendor/bundle/ruby/2.5.0/gems/puppet-6.17.0/lib/puppet/node/environment.rb:43:in `create'
 # ./vendor/bundle/ruby/2.5.0/gems/puppet-6.17.0/lib/puppet.rb:240:in `base_context'
 # ./vendor/bundle/ruby/2.5.0/gems/puppet-6.17.0/lib/puppet/test/test_helper.rb:53:in `initialize'
 # ./vendor/bundle/ruby/2.5.0/gems/rspec-puppet-2.7.8/lib/rspec-puppet.rb:77:in `block in <top (required)>'
 # ./vendor/bundle/ruby/2.5.0/gems/rspec-puppet-2.7.8/lib/rspec-puppet.rb:34:in `<top (required)>'
 # ./vendor/bundle/ruby/2.5.0/gems/puppetlabs_spec_helper-2.15.0/lib/puppetlabs_spec_helper/module_spec_helper.rb:1:in `require'
 # ./vendor/bundle/ruby/2.5.0/gems/puppetlabs_spec_helper-2.15.0/lib/puppetlabs_spec_helper/module_spec_helper.rb:1:in `<top (required)>'
 # ./spec/spec_helper.rb:7:in `require'
 # ./spec/spec_helper.rb:7:in `<top (required)>'

See also https://github.com/rodjek/rspec-puppet/issues/796.
 

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Josh Cooper (Jira)

unread,
Jul 15, 2020, 1:18:03 PM7/15/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jul 15, 2020, 1:18:04 PM7/15/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jul 15, 2020, 1:18:04 PM7/15/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jul 15, 2020, 1:18:04 PM7/15/20
to puppe...@googlegroups.com

Melissa Amos (Jira)

unread,
Jul 15, 2020, 1:45:03 PM7/15/20
to puppe...@googlegroups.com
Melissa Amos updated an issue
Change By: Melissa Amos
Affects Version/s: PUP 6.17.0
Affects Version/s: PUP 5.5.21

Melissa Amos (Jira)

unread,
Jul 15, 2020, 1:51:04 PM7/15/20
to puppe...@googlegroups.com
Melissa Amos updated an issue
Change By: Melissa Amos
Release Notes: Known Issue
Release Notes Summary: Testing modules using rspec-puppet versions earlier than 2.7.10 results in ... <SUMMARIZE USER-FACING ISSUE> As a workaround, update rspec-puppet to version 2.7.10 or later: <COMMAND TO UPDATE GEM>

Melissa Amos (Jira)

unread,
Jul 15, 2020, 1:52:03 PM7/15/20
to puppe...@googlegroups.com
Melissa Amos commented on Bug PUP-10586
 
Re: Regression: Puppet::Util.default_env method removed in 5.5.21 and 6.17.0

Josh Cooper Can you please help fill in the blanks on the DOCS tab.

Josh Cooper (Jira)

unread,
Jul 15, 2020, 2:17:04 PM7/15/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Change By: Josh Cooper
Release Notes Summary: Testing modules using rspec-puppet versions earlier than 2.7.10 results in the error "undefined local variable or method `default_env' for Puppet::Util:Module" . .. <SUMMARIZE USER-FACING ISSUE> As a workaround, update rspec-puppet to version 2.7.10 . If using PDK, run `pdk bundle update rspec-puppet` or later: <COMMAND TO UPDATE GEM> update your PDK package. If not using PDK, run `bundle update`.

Josh Cooper (Jira)

unread,
Jul 16, 2020, 1:05:04 PM7/16/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jul 16, 2020, 1:06:02 PM7/16/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jul 16, 2020, 1:06:03 PM7/16/20
to puppe...@googlegroups.com

Claire Cadman (Jira)

unread,
Jul 21, 2020, 11:52:03 AM7/21/20
to puppe...@googlegroups.com

Josh Cooper this is added as a known issue here: https://tickets.puppetlabs.com/browse/PUP-10586. So the docs tab can be updated to be a resolved issue now. I'll remove the known issue when the next release goes out and add it to the bug fixes. Thanks! 

Claire Cadman (Jira)

unread,
Aug 13, 2020, 5:54:03 AM8/13/20
to puppe...@googlegroups.com

Claire Cadman (Jira)

unread,
Aug 13, 2020, 5:55:03 AM8/13/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Aug 20, 2020, 2:01:06 PM8/20/20
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages