Jira (PDB-4804) Don't leave maintenance mode during deferred shutdowns

[Rob Browning (Jira)]

Rob Browning updated an issue

PuppetDB / PDB-4804 Don't leave maintenance mode during deferred shutdowns Change By: Rob Browning Summary: Don't defer shutdown for cases intended to be immediate leave maintenance mode during deferred shutdowns Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Rob Browning (Jira)]

Rob Browning updated an issue

PuppetDB / PDB-4804 Don't leave maintenance mode during deferred shutdowns Change By: Rob Browning

Our previous adjustments to shutdown in a friendlier way for appropriate errors (PDB-4627) ecb22d3a0fc4579d5e94075d57634bdf6df880fa, we ended up deferring some shutdowns that should have been immediate (i.e. if the config were broken). because request-shutdown only initiates the shutdown after all services have finished starting (if none of them throw an exception).  This is a problem because the PuppetDBServer was not necessarily left in a consistent state for other dependent services like the command dispatcher. Since TK doesn't have a way to initiate an immediate friendly shutdown yet, for now, as a mitigation, just make sure we can't come out of maintenance mode during the ( unavoidably deferred ) shutdown shutdowns , until we resolve PDB-4805.

Add Comment

[Rob Browning (Jira)]

Rob Browning updated an issue

PuppetDB / PDB-4804 Don't leave maintenance mode during deferred shutdowns

Change By: Rob Browning Release Notes: Bug Fix Not Needed Release Notes Summary: For the moment, PuppetDB has reverted to its previous behavior which produced much noisier errors in some cases (e.g. for some configuration errors), but the friendlier behavior may be restored in a future release.

Add Comment