Jira (FACT-2662) Fix test that mock subject

[Bogdan Irimie (Jira)]

Bogdan Irimie created an issue

Facter / FACT-2662 Fix test that mock subject Issue Type: Task Assignee: Unassigned Created: 2020/06/11 7:21 AM Priority: Normal Reporter: Bogdan Irimie Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

Facter / FACT-2662 Fix test that mock subject

Change By: Bogdan Irimie    {code} spec/custom_facts/core/execution/fact_manager_spec.rb:83:7: C: RSpec/SubjectStub: Do not stub methods of the object under test. [12|https://github.com/puppetlabs/facter-ng/pull/549/checks?check_run_id=761883097#step:5:12] expect(executor).to receive(:with_env).with('LC_ALL' => 'C', 'LANG' => 'C') [13|https://github.com/puppetlabs/facter-ng/pull/549/checks?check_run_id=761883097#step:5:13] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [14|https://github.com/puppetlabs/facter-ng/pull/549/checks?check_run_id=761883097#step:5:14]spec/custom_facts/core/execution/fact_manager_spec.rb:89:7: C: RSpec/SubjectStub: Do not stub methods of the object under test. [15|https://github.com/puppetlabs/facter-ng/pull/549/checks?check_run_id=761883097#step:5:15] expect(executor).to receive(:expand_command).with('foo').and_return '/bin/foo' [16|https://github.com/puppetlabs/facter-ng/pull/549/checks?check_run_id=761883097#step:5:16] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [17|https://github.com/puppetlabs/facter-ng/pull/549/checks?check_run_id=761883097#step:5:17]spec/custom_facts/core/execution/fact_manager_spec.rb:152:9: C: RSpec/SubjectStub: Do not stub methods of the object under test. [18|https://github.com/puppetlabs/facter-ng/pull/549/checks?check_run_id=761883097#step:5:18] allow(executor).to receive(:expand_command).with('foo').and_return(nil) [19|https://github.com/puppetlabs/facter-ng/pull/549/checks?check_run_id=761883097#step:5:19] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [20|https://github.com/puppetlabs/facter-ng/pull/549/checks?check_run_id=761883097#step:5:20]spec/custom_facts/core/execution/fact_manager_spec.rb:157:9: C: RSpec/SubjectStub: Do not stub methods of the object under test. [21|https://github.com/puppetlabs/facter-ng/pull/549/checks?check_run_id=761883097#step:5:21] allow(executor).to receive(:expand_command).with('foo').and_return(nil) [22|https://github.com/puppetlabs/facter-ng/pull/549/checks?check_run_id=761883097#step:5:22] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [23|https://github.com/puppetlabs/facter-ng/pull/549/checks?check_run_id=761883097#step:5:23]spec/custom_facts/core/execution/fact_manager_spec.rb:165:9: C: RSpec/SubjectStub: Do not stub methods of the object under test. [24|https://github.com/puppetlabs/facter-ng/pull/549/checks?check_run_id=761883097#step:5:24] allow(executor).to receive(:expand_command).with('foo').and_return('/bin/foo') [25|https://github.com/puppetlabs/facter-ng/pull/549/checks?check_run_id=761883097#step:5:25] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [26|https://github.com/puppetlabs/facter-ng/pull/549/checks?check_run_id=761883097#step:5:26]spec/custom_facts/core/execution/fact_manager_spec.rb:179:7: C: RSpec/SubjectStub: Do not stub methods of the object under test. [27|https://github.com/puppetlabs/facter-ng/pull/549/checks?check_run_id=761883097#step:5:27] allow(executor).to receive(:expand_command).with('foo').and_return '/bin/foo' [28|https://github.com/puppetlabs/facter-ng/pull/549/checks?check_run_id=761883097#step:5:28] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [29|https://github.com/puppetlabs/facter-ng/pull/549/checks?check_run_id=761883097#step:5:29]spec/custom_facts/core/execution/fact_manager_spec.rb:186:7: C: RSpec/SubjectStub: Do not stub methods of the object under test. [30|https://github.com/puppetlabs/facter-ng/pull/549/checks?check_run_id=761883097#step:5:30] allow(executor).to receive(:expand_command).with('foo').and_return '/bin/foo' {code}

Add Comment

[Oana Tanasoiu (Jira)]

Oana Tanasoiu assigned an issue to Oana Tanasoiu

Facter / FACT-2662 Fix test that mock subject

Change By: Oana Tanasoiu Assignee: Oana Tanasoiu

Add Comment

[Oana Tanasoiu (Jira)]

Oana Tanasoiu updated an issue

Facter / FACT-2662 Fix test that mock subject

Change By: Oana Tanasoiu Story Points: 1

Add Comment