Jira (FACT-2643) Timeout on resolution

17 views
Skip to first unread message

Andrei Filipovici (Jira)

unread,
May 28, 2020, 8:05:03 AM5/28/20
to puppe...@googlegroups.com
Andrei Filipovici created an issue
 
Facter / Task FACT-2643
Timeout on resolution
Issue Type: Task Task
Assignee: Unassigned
Created: 2020/05/28 5:04 AM
Priority: Normal Normal
Reporter: Andrei Filipovici

Timeout on resolution does nothing on Facter 4 and on Facter 3 it shows a warning saying that timeout is not supported on custom facts.

Further investigation is needed.
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Mihai Buzgau (Jira)

unread,
Aug 11, 2020, 8:24:03 AM8/11/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: ready for triage

Bogdan Irimie (Jira)

unread,
Aug 19, 2020, 9:47:03 AM8/19/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ready for triage

Bogdan Irimie (Jira)

unread,
Sep 30, 2020, 9:02:49 AM9/30/20
to puppe...@googlegroups.com

Bogdan Irimie (Jira)

unread,
Sep 30, 2020, 9:17:03 AM9/30/20
to puppe...@googlegroups.com
Bogdan Irimie commented on Task FACT-2643
 
Re: Timeout on resolution

Investigate timeout on Facter 3.

Option 1:

  • throw error if "time" option is used
  • investigate what breaks when we throw error

Option 2:

  • check time option in custom facts on Facter 4 (does it work, what does it do, is it similar to Facter 2?)

Bogdan Irimie (Jira)

unread,
Sep 30, 2020, 9:19:04 AM9/30/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ready for triage ghost-7.10

Bogdan Irimie (Jira)

unread,
Sep 30, 2020, 9:19:04 AM9/30/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Story Points: 2

Oana Tanasoiu (Jira)

unread,
Oct 7, 2020, 2:41:03 AM10/7/20
to puppe...@googlegroups.com
Oana Tanasoiu assigned an issue to Oana Tanasoiu
Change By: Oana Tanasoiu
Assignee: Oana Tanasoiu

Bogdan Irimie (Jira)

unread,
Oct 7, 2020, 9:05:04 AM10/7/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ghost-7.10 , ready for triage 2

Bogdan Irimie (Jira)

unread,
Oct 9, 2020, 9:30:03 AM10/9/20
to puppe...@googlegroups.com
 
Re: Timeout on resolution

We should discuss if we want to remove this feature. In Facter 4 it works as it did in Facter 2. It seams that it was removed from Facter 3 because it was hard to guarantee it with native code https://tickets.puppetlabs.com/browse/CFACT-44

Oana Tanasoiu (Jira)

unread,
Oct 14, 2020, 2:57:04 AM10/14/20
to puppe...@googlegroups.com
Oana Tanasoiu commented on Task FACT-2643
 
Re: Timeout on resolution

Facter 3 doesn't support timeout option for custom facts, it logs a warning message when a user tries to set that option.
We decided to keep the mechanism that sets timeout on resolution on Facter 4 and to add an acceptance test to verify that the behaviour is indeed as expected.

Bogdan Irimie (Jira)

unread,
Oct 14, 2020, 10:04:04 AM10/14/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ghost-7.10, ghost-14.10 , ready for triage 2

Mihai Buzgau (Jira)

unread,
Nov 5, 2020, 9:40:03 AM11/5/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Fix Version/s: FACT 4.0.45

Bogdan Irimie (Jira)

unread,
Nov 5, 2020, 10:07:03 AM11/5/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Release Notes: Not Needed Enhancement
Release Notes Summary: Users can now specify `timeout` attribute in custom fact options. The timeout is for a custom facts resolution.

Claire Cadman (Jira)

unread,
Nov 10, 2020, 6:00:03 AM11/10/20
to puppe...@googlegroups.com
Claire Cadman updated an issue
Change By: Claire Cadman
Labels: doc_reviewed platform_7
Reply all
Reply to author
Forward
0 new messages