Jira (FACT-2634) Add acceptance test for error in custom facts

17 views
Skip to first unread message

Bogdan Irimie (Jira)

unread,
May 25, 2020, 3:31:03 AM5/25/20
to puppe...@googlegroups.com
Bogdan Irimie created an issue
 
Facter / Task FACT-2634
Add acceptance test for error in custom facts
Issue Type: Task Task
Assignee: Unassigned
Created: 2020/05/25 12:30 AM
Priority: Normal Normal
Reporter: Bogdan Irimie
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Bogdan Irimie (Jira)

unread,
May 25, 2020, 3:57:04 AM5/25/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
The test should contain two files with custom facts. The first file should contain 3 custom facts, with an error after the first fact e.g.

{code}
Facter.add(:custom_fact_1) do
  setcode do
      'custom_fact_1_value'
  end
end

# some error
nill.size

Facter.add(:custom_fact_2) do
  setcode do
      'custom_fact_2_value'
  end
end

Facter.add(:custom_fact_3) do
  setcode do
      'custom_fact_3_value'
  end
end
{code}

Bogdan Irimie (Jira)

unread,
May 25, 2020, 4:13:04 AM5/25/20
to puppe...@googlegroups.com

The second file should contain a custom fact e.g.
{code}Facter.add(:custom_fact_4) do
  setcode do
      'custom_fact_4_value'
  end
end
{code}
We should check the fallowing:
# Facter.to_hash works
# Facter.value(<some_core_fact>) returns correct value
# Facter.value('custom_fact_1') returns 'custom_fact_1_value'
# Facter.value('custom_fact_4') returns 'custom_fact_4_value'
# Facter.value('custom_fact_2') does not return any value
# Facter.value('custom_fact_3') does not return any value
# Facter logs an error message when loading first file with custom facts

Mihai Buzgau (Jira)

unread,
Aug 11, 2020, 7:08:03 AM8/11/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Epic Link: FACT-2154

Mihai Buzgau (Jira)

unread,
Aug 11, 2020, 8:24:04 AM8/11/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: ready for triage

Bogdan Irimie (Jira)

unread,
Aug 19, 2020, 10:00:04 AM8/19/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ready for triage ghost-26.08

Bogdan Irimie (Jira)

unread,
Aug 19, 2020, 10:01:07 AM8/19/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Story Points: 2

Bogdan Irimie (Jira)

unread,
Aug 26, 2020, 9:04:06 AM8/26/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ghost-26.08 , ready for triage 2

Andrei Filipovici (Jira)

unread,
Sep 1, 2020, 10:53:03 AM9/1/20
to puppe...@googlegroups.com
Andrei Filipovici assigned an issue to Andrei Filipovici
Change By: Andrei Filipovici
Assignee: Andrei Filipovici

Bogdan Irimie (Jira)

unread,
Sep 2, 2020, 9:07:04 AM9/2/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ghost-26.08, ghost-2.09 , ready for triage 2

Bogdan Irimie (Jira)

unread,
Sep 9, 2020, 9:08:04 AM9/9/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ghost-26.08, ghost-2.09, ghost-9.09 , ready for triage 2

Bogdan Irimie (Jira)

unread,
Sep 16, 2020, 9:11:05 AM9/16/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ghost-26.08, ghost-2.09, ghost-9.09, ghost-16.09 , ready for triage 2
Reply all
Reply to author
Forward
0 new messages