| Commit https://github.com/puppetlabs/puppet/commit/7d8b0d37664e1bdf274bfa04ccf7ef5e5ab425eb#diff-c6a03ccca02fa0c4815d03fba3017602L192-R179 disable the job that runs the daemonized agent. As a result, puppet would never run when started as a service on *nix platforms. Had this gotten out we would have had to yank the release as daemonized agents would never run, so you couldn't use puppet to fix/update them. Fortunately we noticed and fixed it before release (https://github.com/puppetlabs/puppet/commit/58c02cceda56025623ad5bc227579a9aaeddfc80) but we have some gaps in test coverage. It looks like our service test is getting skipped due to the medium tag, https://github.com/puppetlabs/puppet/blob/58c02cceda56025623ad5bc227579a9aaeddfc80/acceptance/tests/resource/service/puppet_service_management.rb#L3, though I don't think that would have been sufficient to detect this issue. We either need a new test that verifies the service can be started and run in the background or update the existing test. The success or failure of the run could be detected by the last run summary file that the agent produces or ensuring the master receives a report for that node. /cc Mihai Buzgau, John Duarte, Christopher Thorn |
