Jira (FACT-2632) Log error when we cannot load custom fact from file

[Bogdan Irimie (Jira)]

Bogdan Irimie created an issue

Facter / FACT-2632 Log error when we cannot load custom fact from file Issue Type: Bug Assignee: Unassigned Created: 2020/05/21 5:23 AM Priority: Normal Reporter: Bogdan Irimie Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Bogdan Irimie (Jira)]

Bogdan Irimie assigned an issue to Bogdan Irimie

Facter / FACT-2632 Log error when we cannot load custom fact from file

Change By: Bogdan Irimie Assignee: Bogdan Irimie

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

Facter / FACT-2632 Log error when we cannot load custom fact from file Change By: Bogdan Irimie

Facter 4 is failing when there is an exception in the file with a custom fact. The failure should be outside `Facter.add(...)` Custom fact example: {code}# frozen_string_literal: true nil.size Facter.add(:my_custom_fact) do   has_weight(10_000)   setcode do     'my_custom_fact'   end end {code} Facter 3 on the other hand, logs an error message, but still resolves all the facts that is able to. We should implement the same behaviour in Facter 4.

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

Facter / FACT-2632 Log error when we cannot load custom fact from file Change By: Bogdan Irimie

Facter 4 is failing when there is an exception in the file with a custom fact. The failure should be outside `Facter.add(...)` Custom fact example: {code}# frozen_string_literal: true nil.size Facter.add(:my_custom_fact) do   has_weight(10_000)   setcode do     'my_custom_fact'   end end {code}

Facter 3 on the other hand, logs an error message for the files with exceptions , but still resolves all the other facts that is able to . We should implement the same behaviour in Facter 4.

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

Facter / FACT-2632 Log error when we cannot load custom fact from file Change By: Bogdan Irimie

Facter 4 is failing when there is an exception in the file with a custom fact. The failure should be outside `Facter.add(...)` Custom fact example: {code}# frozen_string_literal: true nil.size Facter.add(:my_custom_fact) do   has_weight(10_000)   setcode do     'my_custom_fact'   end end {code}

Facter 3 on the other hand, logs an error message for the files with exceptions, but still resolves all other facts. We should implement the same behaviour in Facter 4. The error message should be {code}ERROR Facter - error while resolving custom facts in  <path_to_custom_facts>/my_custom_fact.rb undefined method `size' for nil:NilClass {code}

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on FACT-2632

Re: Log error when we cannot load custom fact from file For future facter releases can you add release notes for tickets like this?

Add Comment

[Garrett Guillotte (Jira)]

Garrett Guillotte updated an issue

Facter / FACT-2632

Log error when we cannot load custom fact from file

Change By: Garrett Guillotte Release Notes: Not Needed Bug Fix

Add Comment

[Garrett Guillotte (Jira)]

Garrett Guillotte updated an issue

Facter / FACT-2632 Log error when we cannot load custom fact from file

Change By: Garrett Guillotte Release Notes Summary: Previous verisons of Facter 4 would fail and report an error when resolving invalid custom facts. This was a potentially breaking change in behavior compared to Facter 3, which logged errors for failed facts but continued resolving other facts. Facter 4.0.28 resolves this issue by using the same behavior as Facter 3.

Add Comment

[Garrett Guillotte (Jira)]

Garrett Guillotte updated an issue

Facter / FACT-2632 Log error when we cannot load custom fact from file

Change By: Garrett Guillotte Release Notes Summary: Previous verisons of Facter 4 would fail and report an error when resolving invalid custom facts. This was a potentially breaking change in behavior compared to Facter 3, which logged errors for failed facts but continued resolving other facts. Facter 4.0. 28 23 resolves this issue by using the same behavior as Facter 3.

Add Comment