Jira (PDB-4741) Report type AST processor does not allow nil expressions

[Austin Blatt (Jira)]

Austin Blatt created an issue

PuppetDB / PDB-4741 Report type AST processor does not allow nil expressions Issue Type: Bug Assignee: Austin Blatt Created: 2020/05/18 1:32 PM Fix Versions: PDB 6.11.0 Priority: Normal Reporter: Austin Blatt We allow nil expressions in extract statements in AST, but the AST processor added for filtering reports by type does not support nil expressions. The following query is generated by the console when querying to a package count when there is no filtering being done on package_name. code ["from" "package_inventory" ["extract" ["package_name" "version" "provider" ["function" "count"]] ["and" ["=" ["node" "active"] "true"] ["in" ["package_name" "version" "provider"] ["from" "packages" ["extract" ["package_name" "version" "provider"] nil] ["order_by" ["package_name" "version" "provider"]] ["limit" 1000000] ["offset" 0]]]] ["group_by" "package_name" "version" "provider"]]] code That query will fail with the message Unrecognized ast clause ["in" ["package_name" "version" "provider"] ["from" "packages" ["extract" ["package_name" "version" "provider"] nil] because nil is not one of the allowed expression formats in maybe-add-agent-report-filter Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Austin Blatt (Jira)]

Austin Blatt updated an issue

PuppetDB / PDB-4741 Report type AST processor does not allow nil expressions

Change By: Austin Blatt

We allow nil expressions in extract statements in AST, but the AST processor added for filtering reports by type does not support nil expressions.

The following query is generated by the console when querying to a package count when there is no filtering being done on {{package_name}}. { { code} }

["from" "package_inventory" ["extract" ["package_name" "version" "provider" ["function" "count"]] ["and"   ["=" ["node" "active"] "true"]   ["in"    ["package_name" "version" "provider"]    ["from"     "packages"     ["extract" ["package_name" "version" "provider"] nil]     ["order_by" ["package_name" "version" "provider"]]     ["limit" 1000000]     ["offset" 0]]]] ["group_by" "package_name" "version" "provider"]]] {

{ code} }

That query will fail with the message {{Unrecognized ast clause ["in" ["package_name" "version" "provider"] ["from" "packages" ["extract" ["package_name" "version" "provider"] nil]}} because {{nil}} is not one of the allowed expression formats in {{maybe-add-agent-report-filter}}

Add Comment

[Austin Blatt (Jira)]

Austin Blatt commented on PDB-4741

Re: Report type AST processor does not allow nil expressions Also, the new processor does not recognize the "offset" paging option.

Add Comment