Jira (PUP-10503) hiera glob files not included in order

10 views
Skip to first unread message

Stefan Bühler

unread,
May 12, 2020, 3:03:03 PM5/12/20
to puppe...@googlegroups.com
Stefan Bühler created an issue
 
Puppet / Bug PUP-10503
hiera glob files not included in order
Issue Type: Bug Bug
Affects Versions: PUP 5.5.10
Assignee: Unassigned
Components: Hiera & Lookup
Created: 2020/05/12 12:02 PM
Priority: Normal Normal
Reporter: Stefan Bühler

Puppet Version: 5.5.10-4
Puppet Server Version: 5.5.10-4 (puppet-master-passenger)
OS Name/Version: debian buster

The documentation claims "If multiple files are found, Hiera searches all of them in alphanumerical order."

This doesn't actually happen.

When I insert a .sort before the .map in https://github.com/puppetlabs/puppet/blob/master/lib/puppet/pops/lookup/location_resolver.rb#L44 it works, although it probably still fails the documentation claim for globs - to get that right, I think one would need to define a comparision for ResolvedLocation objects based on their location, and add .sort after .flatten in line 45.

It is possible newer versions added sorting somewhere else, but I can't find it.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Henrik Lindberg (Jira)

unread,
May 12, 2020, 6:13:03 PM5/12/20
to puppe...@googlegroups.com
Henrik Lindberg commented on Bug PUP-10503
 
Re: hiera glob files not included in order

You are right, it does not sort. It should do that - it was a design criteria that went missing in the implementation (i.e. the documentation is "right").

Rob Braden (Jira)

unread,
May 18, 2020, 1:51:04 PM5/18/20
to puppe...@googlegroups.com
Rob Braden updated an issue
 
Change By: Rob Braden
Team: Froyo

Josh Cooper (Jira)

unread,
Aug 19, 2021, 1:47:03 AM8/19/21
to puppe...@googlegroups.com
Josh Cooper assigned an issue to Josh Cooper
Change By: Josh Cooper
Assignee: Josh Cooper
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages