Jira (PUP-2587) circular inheritance causes stack too deep error

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-2587 circular inheritance causes stack too deep error Change By: Henrik Lindberg Scrum Team: Language Add Comment

This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)

[Charlie Sharpsteen (JIRA)]

Charlie Sharpsteen updated an issue

Puppet / PUP-2587 circular inheritance causes stack too deep error

Change By: Charlie Sharpsteen Affects Version/s: PUP 4.2.1

Add Comment

This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4)

[Charlie Sharpsteen (JIRA)]

Charlie Sharpsteen updated an issue

Puppet / PUP-2587 circular inheritance causes stack too deep error

Change By: Charlie Sharpsteen Affects Version/s: PUP 3.8.2

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg assigned an issue to Unassigned

Puppet / PUP-2587 circular inheritance causes stack too deep error

Change By: Henrik Lindberg Assignee: Andrew Parker

Add Comment

This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-2587 circular inheritance causes stack too deep error

Change By: Henrik Lindberg Team: Puppet Developer Support

Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-2587 circular inheritance causes stack too deep error

Change By: Henrik Lindberg Component/s: DSL Component/s: Language

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-2587 circular inheritance causes stack too deep error

Change By: Henrik Lindberg Fix Version/s: PUP 4.y

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Puppet / PUP-2587 circular inheritance causes stack too deep error

Change By: Branan Riley Story Points: 2

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Puppet / PUP-2587 circular inheritance causes stack too deep error

Change By: Branan Riley Team: Puppet Developer Experience Agent

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Puppet / PUP-2587 circular inheritance causes stack too deep error

Change By: Branan Riley Labels: triaged

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza updated an issue

Puppet / PUP-2587 circular inheritance causes stack too deep error

Change By: Moses Mendoza Labels: triaged

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-2587

Re: circular inheritance causes stack too deep error This is no longer reproducible using 6.12.0: [root@softer-dearth ~]# cat /etc/puppetlabs/code/environments/production/manifests/site.pp class foo inherits foo { } [root@softer-dearth ~]# puppet agent -t Info: Using configured environment 'production' Info: Retrieving pluginfacts Info: Retrieving plugin Info: Retrieving locales Info: Caching catalog for softer-dearth.delivery.puppetlabs.net Info: Applying configuration version '1579807952' Notice: Applied catalog in 0.01 seconds

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Henrik Lindberg (JIRA)]

Henrik Lindberg commented on PUP-2587

Re: circular inheritance causes stack too deep error

If it did not error out then that is a problem. Maybe combine fixing that with the ticket about validating that a class does not require itself.

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-2587

Re: circular inheritance causes stack too deep error

Dang.. yeah it's still a problem. I think the code was ignored due to the class not being included. Given:

[root@softer-dearth ~]# cat /etc/puppetlabs/code/environments/production/manifests/site.pp

include foo [root@softer-dearth ~]# cat /etc/puppetlabs/code/environments/production/modules/foo/manifests/init.pp class foo inherits foo { } An agent run cause the server to stackoverflow.   2020-01-24T01:00:11.128Z WARN  [qtp1400473817-35] [o.e.j.s.HttpChannel] /puppet/v3/catalog/softer-dearth.delivery.puppetlabs.net2020-01-24T01:00:11.128Z WARN  [qtp1400473817-35] [o.e.j.s.HttpChannel] /puppet/v3/catalog/softer-dearth.delivery.puppetlabs.netjava.lang.StackOverflowError: null at opt.puppetlabs.puppet.lib.ruby.vendor_ruby.puppet.resource.invokeOther12:known_resource_types(/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/resource.rb:378) at opt.puppetlabs.puppet.lib.ruby.vendor_ruby.puppet.resource.RUBY$method$resource_type$0(/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/resource.rb:378) at org.jruby.internal.runtime.methods.CompiledIRMethod.call(CompiledIRMethod.java:143) at org.jruby.internal.runtime.methods.MixedModeIRMethod.call(MixedModeIRMethod.java:221) at org.jruby.internal.runtime.methods.DynamicMethod.call(DynamicMethod.java:216) at org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:234)

Add Comment

[David McTavish (Jira)]

David McTavish updated an issue

Puppet / PUP-2587

circular inheritance causes stack too deep error

Change By: David McTavish Labels: final_triage

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-2587 circular inheritance causes stack too deep error

Change By: Josh Cooper Team: Froyo

Add Comment