Jira (PUP-10485) pip package provider does not handle pip executable paths with spaces

[Thomas Kishel (Jira)]

Thomas Kishel created an issue

Puppet / PUP-10485 pip package provider does not handle pip executable paths with spaces Issue Type: Bug Assignee: Unassigned Created: 2020/05/01 1:20 PM Priority: Normal Reporter: Thomas Kishel Puppet Version: 6.4.5 and 6.14.0 OS Name/Version: Windows On a Windows Server 2016 node running Puppet 6.4.5 and 6.14.0 with Python installed in a path with spaces, the Puppet catalog returns the below error if package collection is enabled: Cannot collect packages for Puppet::Type::Package::ProviderPip provider; [nil, nil] More specifically, this issue was fixed in PUP-9647 for getting the pip version, but this was not fixed when Puppet executes the `pip freeze -all' command to get the packages.  Desired Behavior: Quote function should be added to the pip provider here: https://github.com/puppetlabs/puppet/blob/6.14.0/lib/puppet/provider/package/pip.rb#L79   Relevant sections of configurations files (puppet.conf, hiera.conf, Server's conf.d, defaults/sysconfig) For memory issues with server heap dumps are also helpful. Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Thomas Kishel (Jira)]

Thomas Kishel commented on PUP-10485

Re: pip package provider does not handle pip executable paths with spaces Possibly, other calls to execute the command need to be quoted using quote() ... https://github.com/puppetlabs/puppet/blob/6.14.0/lib/puppet/provider/package/pip.rb#L142 https://github.com/puppetlabs/puppet/blob/6.14.0/lib/puppet/provider/package/pip.rb#L166 https://github.com/puppetlabs/puppet/blob/6.14.0/lib/puppet/provider/package/pip.rb#L206

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10485

pip package provider does not handle pip executable paths with spaces

Change By: Josh Cooper Team: Night's Watch

Add Comment

[Thomas Kishel (Jira)]

Thomas Kishel commented on PUP-10485

Re: pip package provider does not handle pip executable paths with spaces Note that this affects out Packages (View packages in use across your infrastructure) feature.

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10485

pip package provider does not handle pip executable paths with spaces

Change By: Mihai Buzgau Sprint: PR - Triage

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10485 pip package provider does not handle pip executable paths with spaces

Change By: Mihai Buzgau Story Points: 2

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10485 pip package provider does not handle pip executable paths with spaces

Change By: Mihai Buzgau Sprint: PR NW - Triage 2020-05-13

Add Comment

[Luchian Nemes (Jira)]

Luchian Nemes assigned an issue to Luchian Nemes

Puppet / PUP-10485 pip package provider does not handle pip executable paths with spaces

Change By: Luchian Nemes Assignee: Luchian Nemes

Add Comment

[Luchian Nemes (Jira)]

Luchian Nemes commented on PUP-10485

Re: pip package provider does not handle pip executable paths with spaces Reviewed your changes Thomas Kishel and added some unit tests to cover them. Looks good to me but someone else from the team should also take a look at the pull request as a whole before proceeding to merge.

Add Comment

[Luchian Nemes (Jira)]

Luchian Nemes updated an issue

Puppet / PUP-10485

pip package provider does not handle pip executable paths with spaces

Change By: Luchian Nemes Release Notes: Bug Fix Release Notes Summary: Paths containing spaces will now be quoted in pip package provider as it caused issues on Windows when executing CLI commands.

Add Comment

[Gheorghe Popescu (Jira)]

Gheorghe Popescu updated an issue

Puppet / PUP-10485 pip package provider does not handle pip executable paths with spaces

Change By: Gheorghe Popescu Fix Version/s: PUP 6.16.0

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Puppet / PUP-10485 pip package provider does not handle pip executable paths with spaces

Change By: Claire Cadman Labels: doc_reviewed

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-10485 pip package provider does not handle pip executable paths with spaces

Change By: Ciprian Badescu Fix Version/s: PUP 5.5.21

Add Comment