Jira (PUP-10445) Add deprecation warning to find/search/save/destroy methods in the abstract rest terminus

19 views
Skip to first unread message

Josh Cooper (Jira)

unread,
Apr 24, 2020, 4:20:04 PM4/24/20
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Bug PUP-10445
Add deprecation warning to find/search/save/destroy methods in the abstract rest terminus
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2020/04/24 1:19 PM
Fix Versions: PUP 6.16.0
Priority: Normal Normal
Reporter: Josh Cooper

Add deprecation warnings to the find/search/save/destroy methods to the Puppet::Indirection::Rest.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Josh Cooper (Jira)

unread,
Apr 24, 2020, 4:21:03 PM4/24/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Apr 24, 2020, 6:00:03 PM4/24/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Apr 24, 2020, 8:19:03 PM4/24/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Apr 27, 2020, 8:06:03 PM4/27/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Apr 27, 2020, 8:07:03 PM4/27/20
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-10445
 
Re: Add deprecation warning to find/search/save/destroy methods in the abstract rest terminus

I started on this and realized we need to implement the adapter so that the deprecation warning isn't always triggered when using classifier terminus, etc, so putting this in needs information.

Josh Cooper (Jira)

unread,
Apr 30, 2020, 2:32:03 PM4/30/20
to puppe...@googlegroups.com

Melissa Stone (Jira)

unread,
May 5, 2020, 2:15:03 PM5/5/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
May 5, 2020, 11:29:04 PM5/5/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Release Notes: Deprecation
Release Notes Summary: Calling Puppet::Indirection::Rest.{find,search,save,destroy,head} is deprecated as part of an effort to separate the indirector and http requests. If a custom terminus extends the abstract rest terminus, then it should implement the networking request itself or call puppet's http client like the builtin rest termini do, such as Puppet::Indirector::Node::Rest.

Josh Cooper (Jira)

unread,
May 6, 2020, 11:59:03 AM5/6/20
to puppe...@googlegroups.com

Claire Cadman (Jira)

unread,
May 19, 2020, 9:54:02 AM5/19/20
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages