Jira (PUP-10440) Remove networking code from the parent REST terminus

[Josh Cooper (Jira)]

Josh Cooper created an issue

Puppet / PUP-10440 Remove networking code from the parent REST terminus Issue Type: Bug Assignee: Unassigned Created: 2020/04/23 2:29 PM Fix Versions: PUP 7.0.0 Priority: Normal Reporter: Josh Cooper In 6.14.0, all of puppet's rest termini for a specific model, e.g. Puppet::Indirector::Catalog::Rest, use the http client to make REST requests. However, the abstract parent Puppet::Indirector::Rest still uses the legacy http code. This ticket is to have the parent's find, search, etc methods raise a NotImplementedError, and delete the supporting methods like headers, network, server, port, srv_service, etc Also delete Puppet::Util::Connection Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Melissa Stone (Jira)]

Melissa Stone commented on PUP-10440

Re: Remove networking code from the parent REST terminus Almost everything in lib/puppet/indirector/rest.rb. We aren't storing state, compression module goes agay, server and port settings, do_request, private methods, handle_response, etc NotImplementedError for get, post, head, etc maybe keep: `use_http_client?` `validate_key` def needs to stay

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10440

Remove networking code from the parent REST terminus

Change By: Josh Cooper In 6.14.0, all of puppet's rest termini for a specific model, e.g. {{Puppet::Indirector::Catalog::Rest}}, use the http client to make REST requests. However, the abstract parent {{Puppet::Indirector::Rest}} still uses the legacy http code.

This ticket is to have the parent's find, search, etc methods raise a NotImplementedError, and delete the supporting methods like headers, network, server, port, srv_service, etc

Also delete Puppet::Util::Connection

Add Comment

[Josh Cooper (Jira)]

Josh Cooper assigned an issue to Josh Cooper

Puppet / PUP-10440 Remove networking code from the parent REST terminus

Change By: Josh Cooper Assignee: Josh Cooper

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10440 Remove networking code from the parent REST terminus

Change By: Josh Cooper Sprint: Platform Core KANBAN

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10440

Remove networking code from the parent REST terminus

Change By: Josh Cooper Issue Type: Bug Task

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10440

Re: Remove networking code from the parent REST terminus Merged to main in c6e708372c

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10440

Re: Remove networking code from the parent REST terminus

Passed CI in 8de594930e

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10440

Remove networking code from the parent REST terminus

Change By: Josh Cooper Release Notes: Bug Fix Release Notes Summary: This is a breaking change for any REST terminus that relies on the parent REST terminus to perform the network request and process the response. REST termini must implement the find, search, save and destroy methods that make sense for their indirected model.

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Puppet / PUP-10440 Remove networking code from the parent REST terminus

Change By: Claire Cadman Labels: doc_reviewed platform_7

Add Comment