Jira (PUP-10439) Remove Puppet::Network::HTTP::ConnectionAdapter

Josh Cooper (Jira)

unread,

Aug 6, 2020, 7:21:04 PM8/6/20

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /

PUP-10439

Remove Puppet::Network::HTTP::ConnectionAdapter

Change By:	Josh Cooper
Summary:	Remove Puppet::Network::HTTP:: Connection ConnectionAdapter

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

Josh Cooper (Jira)

unread,

Aug 6, 2020, 7:23:04 PM8/6/20

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /

PUP-10439

Remove Puppet::Network::HTTP::ConnectionAdapter

Change By:	Josh Cooper

This ticket is to delete deprecated http code and separate client vs server http code:

1. Delete the following classes and tests:

{{Puppet::Network::HTTP::Connection}}
{{Puppet::Network::HTTP::NoCachePool}}
{{Puppet::Network::HTTP::Compression}}

2. Consolidate BasePool and Pool code and tests, since there is only one pool class
3. Rename Puppet::Network::HTTP::Session to something else like PoolEntry
4. Move remaining http client code and tests to `Puppet::HTTP`

{{Puppet::Network::HTTP::Factory}}
{{Puppet::Network::HTTP::Pool}}
{{Puppet::Network::HTTP::PoolEntry}}
{{Puppet::Network::HTTP::Site}}

The classes left in {{Puppet::Network::HTTP::*}} should only be used in a puppetserver context.

This is blocked on PUP-10252

Add Comment

Josh Cooper (Jira)

unread,

Aug 6, 2020, 7:26:04 PM8/6/20

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /

PUP-10439

Remove Puppet::Network::HTTP::ConnectionAdapter

Change By:	Josh Cooper
Release Notes:	Bug Fix
Release Notes Summary:	This contains breaking changes: * Client networking code has been moved to Puppet::HTTP. * Removes Puppet::Network::HttpPool.http_instance method. * Removes Puppet.lookup(:http_pool) * The deprecated Puppet::Network::HttpPool.http_instance and connection methods are preserved.

This ticket is to delete deprecated http code and separate client vs server http code:

1. Delete the following classes and tests:

{{Puppet::Network::HTTP::Connection}}
{{Puppet::Network::HTTP::NoCachePool}}
{{Puppet::Network::HTTP::Compression}}

2. Consolidate BasePool and Pool code and tests, since there is only one pool class
3. Rename Puppet::Network::HTTP::Session to something else like PoolEntry
4. Move remaining http client code and tests to `Puppet::HTTP`

{{Puppet::Network::HTTP::Factory}}
{{Puppet::Network::HTTP::Pool}}
{{Puppet::Network::HTTP::PoolEntry}}
{{Puppet::Network::HTTP::Site}}

The classes left in {{Puppet::Network::HTTP::*}} should only be used in a puppetserver context.

This is blocked on PUP-10252