Jira (PUP-10435) facts provided in a file cannot be used for classification

44 views
Skip to first unread message

Josh Cooper (Jira)

unread,
Apr 22, 2020, 8:50:03 PM4/22/20
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Bug PUP-10435
facts provided in a file cannot be used for classification
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2020/04/22 5:49 PM
Priority: Normal Normal
Reporter: Josh Cooper

If a facts file is provided to puppet lookup, then its contents are merged to the node's facts after classification, which means the lookup may be occur in the wrong environment.

It would be more consistent if facts in the file were merged with the node's facts prior to prior to sending the node request.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Josh Cooper (Jira)

unread,
Apr 22, 2020, 8:51:03 PM4/22/20
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-10435
 
Re: facts provided in a file cannot be used for classification

PUP-7507 added the ability to specify facts in a facts file, but they are added after classification.

Josh Cooper (Jira)

unread,
Apr 22, 2020, 8:52:02 PM4/22/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Apr 22, 2020, 8:52:04 PM4/22/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
If a facts file is provided to puppet lookup, then its contents are merged to the node's facts after classification, which means the lookup may be occur in the wrong environment.

It would be more consistent if lookup retrieved facts in using the file were facts terminus, merged with the node's facts prior to prior to sending file, and submitted the facts in the node request.

Josh Cooper (Jira)

unread,
Apr 23, 2020, 12:44:03 AM4/23/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Coremunity Grooming

Josh Cooper (Jira)

unread,
Apr 23, 2020, 12:44:04 AM4/23/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Coremunity Grooming Hopper

Josh Cooper (Jira)

unread,
May 3, 2021, 2:07:02 PM5/3/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Epic Link: PUP- 6870 11052
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Josh Cooper (Jira)

unread,
Aug 3, 2021, 6:13:04 PM8/3/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Coremunity Hopper , Community PRs 2

Ciprian Badescu (Jira)

unread,
Oct 6, 2021, 4:42:03 AM10/6/21
to puppe...@googlegroups.com

Victor Bobosila (Jira)

unread,
Oct 7, 2021, 3:34:03 AM10/7/21
to puppe...@googlegroups.com

Ciprian Badescu (Jira)

unread,
Oct 20, 2021, 4:20:02 AM10/20/21
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
Change By: Ciprian Badescu
Sprint: NW - 2021-10-20 , NW - 2021-11-03

Ciprian Badescu (Jira)

unread,
Nov 2, 2021, 6:02:05 AM11/2/21
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
Change By: Ciprian Badescu
Fix Version/s: PUP 6.26.0
Fix Version/s: PUP 7.13.0

Ciprian Badescu (Jira)

unread,
Nov 3, 2021, 5:55:03 AM11/3/21
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
Change By: Ciprian Badescu
Sprint: NW - 2021-10-20, NW - 2021-11-03 , NW - 2021-11-17

Josh Cooper (Jira)

unread,
Nov 9, 2021, 3:01:06 PM11/9/21
to puppe...@googlegroups.com

Victor Bobosila (Jira)

unread,
Nov 10, 2021, 3:31:03 AM11/10/21
to puppe...@googlegroups.com

Victor Bobosila (Jira)

unread,
Nov 10, 2021, 3:33:01 AM11/10/21
to puppe...@googlegroups.com
Victor Bobosila updated an issue
Change By: Victor Bobosila
Release Notes Summary: Fixed a bug where facts provided in a file weren't being merged with the facts used for classification. This is because we collected and merged the said facts after the classification happened.
To fix this, we ensured that we resolve the facts that will be used for classification before the node request.

Parker Leach (Jira)

unread,
Dec 8, 2021, 11:19:01 AM12/8/21
to puppe...@googlegroups.com
Parker Leach updated an issue
Change By: Parker Leach
Labels: docs_reviewed
This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages