Jira (PUP-10434) Persistent http connection timeouts can't be changed when using the new http client

[Josh Cooper (Jira)]

Josh Cooper created an issue

Puppet / PUP-10434 Persistent http connection timeouts can't be changed when using the new http client Issue Type: Bug Assignee: Unassigned Created: 2020/04/22 3:43 PM Fix Versions: PUP 6.15.0 Priority: Normal Reporter: Josh Cooper The http client hardcodes the timeout for the http connection pool to 15 seconds. As a result, persistent connections can't be tuned or disabled. This issue existed when the client was created, but only noticed when most of puppet was switched over to use the client for network connections. To reproduce: $ puppet agent -td --http_keepalive_timeout 0 | grep 'Using cached connection' Debug: Using cached connection for https://bleak-scorecard.delivery.puppetlabs.net:8140 Debug: Using cached connection for https://bleak-scorecard.delivery.puppetlabs.net:8140 Debug: Using cached connection for https://bleak-scorecard.delivery.puppetlabs.net:8140 Debug: Using cached connection for https://bleak-scorecard.delivery.puppetlabs.net:8140 Debug: Using cached connection for https://bleak-scorecard.delivery.puppetlabs.net:8140 Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10434 Persistent http connection timeouts can't be changed when using the new http client

Change By: Josh Cooper Sprint: Platform Core KANBAN

Add Comment

[Josh Cooper (Jira)]

Josh Cooper assigned an issue to Josh Cooper

Puppet / PUP-10434 Persistent http connection timeouts can't be changed when using the new http client

Change By: Josh Cooper Assignee: Josh Cooper

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10434

Re: Persistent http connection timeouts can't be changed when using the new http client Merged to master in https://github.com/puppetlabs/puppet/commit/b2f9914ce460a1471e05f7128c040d9325df9e12

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10434

Persistent http connection timeouts can't be changed when using the new http client

Change By: Josh Cooper Release Notes: Bug Fix Release Notes Summary: Fixes a regression in 6.14.0 which caused puppet to cache persistent http connections for 15 seconds instead of the expected 4 seconds, and it was not possible to change the timeout using the Puppet[:http_keepalive_timeout] setting.

Add Comment

[Melissa Stone (Jira)]

Melissa Stone commented on PUP-10434

Re: Persistent http connection timeouts can't be changed when using the new http client This has passed ci with puppet-agent 6.14.0.343.g8871db32

Add Comment

[Melissa Stone (Jira)]

Melissa Stone commented on PUP-10434

Re: Persistent http connection timeouts can't be changed when using the new http client

Josh Cooper the fix version for this is 6.15, but it was merged in after stop ship. Will this be included in the 6.15 release, or will it go out in 6.16?

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10434

Re: Persistent http connection timeouts can't be changed when using the new http client

The yum fix PUP-10432 went into 5.5.x and merged up last night, so this issue will go out in 6.15 too.

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Puppet / PUP-10434

Persistent http connection timeouts can't be changed when using the new http client

Change By: Claire Cadman Labels: doc_reviewed

Add Comment