Jira (PUP-10432) RedHat RHBA-2020:1028 breaks yum.rb in yum provider for some systems

[Matt Schlosser (Jira)]

Matt Schlosser created an issue

Puppet / PUP-10432 RedHat RHBA-2020:1028 breaks yum.rb in yum provider for some systems Issue Type: Bug Assignee: Unassigned Created: 2020/04/21 9:48 AM Priority: Normal Reporter: Matt Schlosser Puppet Version: 5.5.x (probably 6.x as well) Puppet Server Version: NA, but 5.3.x OS Name/Version: RedHat Linux 7.8 Describe your issue in as much detail as possible… Describe steps to reproduce… Desired Behavior: Yum package ensure => latest should ensure latest Actual Behavior: Yum package ensure => latest never finds an update.  Explicit versions work OK. More details: RH added a newline character when subscription manager is enabled. yum.rb looks for first blank line: https://github.com/puppetlabs/puppet/blob/f2709eb5b28894cf017dbe41290d3c0d168e721b/lib/puppet/provider/package/yum.rb#L123-L125     lib/puppet/provider/package/yum.rb:123-125 def self.parse_updates(str) # Strip off all content before the first blank line body = str.partition(/^\s*\n/m).last   As a result, parse_updates returns {} when subscription manager is enabled. Old behavior: # yum check-update Loaded plugins: product-id, search-disabled-repos, subscription-manager This system is not registered with an entitlement server. You can use subscription-manager to register.   New behavior: # yum check-update Loaded plugins: product-id, search-disabled-repos, subscription-manager   This system is not registered with an entitlement server. You can use subscription-manager to register. As a result, parse_updates returns {} when subscription manager is enabled.   workaround 1: disable subscription-manager workaround 2: downgrade subscription-manager Example Code: $app == 'pcmhi' $version == 'latest'  # package     package { $app:         ensure    => $version,         provider  => yum,         require   => Yumrepo[$app],         subscribe => [             Package['nginx'],             Package['python3']         ]     }     Repo Contents: Index of rpm/pcmhi/quality_assurance Name Last modified Size ../ repodata/ 20-Apr-2020 19:28 - pcmhi-3.5.23-0.x86_64.rpm 20-Apr-2020 16:01 19.53 MB pcmhi-3.6.0-0.x86_64.rpm 20-Apr-2020 19:28 23.33 MB Manual Update Check: # yum check-update | grep pcmhi pcmhi.x86_64             1:3.6.0-0             pcmhi   Puppet logs: ^[[0;36mDebug: Executing: '/bin/rpm --version'^[[0m ^[[0;36mDebug: Executing '/bin/rpm -qa --nosignature --nodigest --qf '%{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH}\n' | sort'^[[0m ^[[0;36mDebug: Executing: '/bin/yum check-update'^[[0m   PoC fix for yum.rb:   def self.parse_updates(str)     # Strip off all content before the first blank line     self.debug "parse_updates input #{str}"     body = str.partition(/^\s*\n/m).last     self.debug "parse_updates body #{body}"   updates = Hash.new { |h, k| h[k] = [] }     body.split.each_slice(3) do |tuple|       self.debug "tuple #{tuple}"       break if tuple[0] =~ /^(Obsoleting|Security:|Update)/   Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Matt Schlosser (Jira)]

Matt Schlosser updated an issue

Puppet / PUP-10432 RedHat RHBA-2020:1028 breaks yum.rb in yum provider for some systems

Change By: Matt Schlosser *Puppet Version: 5.5.x (probably 6.x as well)* *Puppet Server Version: NA, but 5.3.x* *OS Name/Version: RedHat Linux 7.8*

Describe your issue in as much detail as possible… Describe steps to reproduce…

*Desired Behavior:*

Yum package ensure => latest should ensure latest

*Actual Behavior:*

Yum package ensure => latest never finds an update.  Explicit versions work OK. More details: RH added a newline character when subscription manager is enabled.

yum.rb looks for first blank line: [https://github.com/puppetlabs/puppet/blob/f2709eb5b28894cf017dbe41290d3c0d168e721b/lib/puppet/provider/package/yum.rb#L123-L125]     {code:java}

lib/puppet/provider/package/yum.rb:123-125 def self.parse_updates(str) # Strip off all content before the first blank line body = str.partition(/^\s*\n/m).last

{code}

As a result, parse_updates returns {} when subscription manager is enabled. Old behavior:

{code:java}

# yum check-update Loaded plugins: product-id, search-disabled-repos, subscription-manager

This system is not registered with an entitlement server. You can use subscription-manager to register.{code}   New behavior: {code:java}

# yum check-update Loaded plugins: product-id, search-disabled-repos, subscription-manager

This system is not registered with an entitlement server. You can use subscription-manager to register.{code}

As a result, parse_updates returns {} when subscription manager is enabled.   workaround 1: disable subscription-manager workaround 2: downgrade subscription-manager

Example Code: $app == 'pcmhi' $version == 'latest'

{code:java}

# package     package { $app:         ensure    => $version,         provider  => yum,         require   => Yumrepo[$app],         subscribe => [             Package['nginx'],             Package['python3']         ]

}{code}     Repo Contents: {code:java}

Index of rpm/pcmhi/quality_assurance Name                     Last modified      Size ../ repodata/                   20-Apr-2020 19:28    - pcmhi-3.5.23-0.x86_64.rpm   20-Apr-2020 16:01  19.53 MB pcmhi-3.6.0-0.x86_64.rpm    20-Apr-2020 19:28  23.33 MB

{code} Manual Update Check: {code:java}

# yum check-update | grep pcmhi

pcmhi.x86_64             1:3.6.0-0             pcmhi{code}   Puppet logs: {code:java}

^[[0;36mDebug: Executing: '/bin/rpm --version'^[[0m ^[[0;36mDebug: Executing '/bin/rpm -qa --nosignature --nodigest --qf '%{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH}\n' | sort'^[[0m

^[[0;36mDebug: Executing: '/bin/yum check-update'^[[0m{code}   PoC fix for yum.rb:   {code:java}

def self.parse_updates(str)     # Strip off all content before the first blank line     self.debug "parse_updates input #{str}"     body = str.partition(/^\s*\n/m).last     self.debug "parse_updates body #{body}"      updates = Hash.new { |h, k| h[k] = [] }     body.split.each_slice(3) do |tuple|       self.debug "tuple #{tuple}"

break if tuple[0] =~ /^(Obsoleting|Security:|Update)/  {code}   Custom Debug Output (bad):     {code:java} Debug: Executing: '/bin/yum check-update' Debug: Puppet::Type::Package::ProviderYum: parse_updates body - note that the subscription manager warning is present on a bad run Debug: Puppet::Type::Package::ProviderYum: ---------------------------- Debug: Puppet::Type::Package::ProviderYum: This system is not registered with an entitlement server. You can use subscription-manager to register. containerd.io.x86_64 1.2.6-3.3.el7 sbai docker-ce.x86_64 3:19.03.5-3.el7 sbai docker-ce-cli.x86_64 1:19.03.5-3.el7 sbai pcmhi.x86_64 1:3.6.0-0 pcmhi puppet-agent.x86_64 5.5.19-1.el7 puppet5 rhn-check.x86_64 2.0.2-24.el7 rhel7 rhn-client-tools.x86_64 2.0.2-24.el7 rhel7 rhn-setup.x86_64 2.0.2-24.el7 rhel7 Debug: Puppet::Type::Package::ProviderYum: ---------------------------- Debug: Puppet::Type::Package::ProviderYum: update tuple - should be name|version|repo: ["This", "system", "is"] Debug: Puppet::Type::Package::ProviderYum: parse_updates output {} {code}   Custom Debug Output (good/with our patch): coming soon

Add Comment

[Matt Schlosser (Jira)]

{code:java} coming soon Debug: Executing: '/bin/yum check-update'

Debug: Puppet::Type::Package::ProviderYum: parse_updates body - note that the subscription manager warning is present on a bad run

Debug: Puppet::Type::Package::ProviderYum: ----------------------------

Debug: Puppet::Type::Package::ProviderYum: containerd.io.x86_64                     1.2.6-3.3.el7         sbai

docker-ce.x86_64                     3:19.03.5-3.el7       sbai    docker-ce-cli.x86_64                     1:19.03.5-3.el7       sbai    pcmhi.x86_64                     1:3.6.0-0             pcmhi   puppet-agent.x86_64                     5.5.19-1.el7          puppet5 rhn-check.x86_64                     2.0.2-24.el7          rhel7   rhn-client-tools.x86_64                     2.0.2-24.el7          rhel7   rhn-setup.x86_64                     2.0.2-24.el7          rhel7

subscription-manager.x86_64                     1.24.26-1.el7         rhel7   subscription-manager-rhsm.x86_64                   1.24.26-1.el7         rhel7   subscription-manager-rhsm-certificates.x86_64      1.24.26-1.el7         rhel7

Debug: Puppet::Type::Package::ProviderYum: ----------------------------

<snip> Debug: Puppet::Type::Package::ProviderYum: update tuple - should be name|version|repo: ["pcmhi.x86_64", "1:3.6.0-0", "pcmhi"] Debug: Puppet::Type::Package::ProviderYum: update_to_hash {:name=>"pcmhi", :epoch=>"1", :version=>"3.6.0", :release=>"0", :arch=>"x86_64"} Debug: Puppet::Type::Package::ProviderYum: short_name pcmhi Debug: Puppet::Type::Package::ProviderYum: long_name pcmhi.x86_64 <snip> Debug: Puppet::Type::Package::ProviderYum: parse_updates output {"containerd.io"=>[{:name=>"containerd.io", :epoch=>"0", :version=>"1.2.6", :release=>"3.3.el7", :arch=>"x86_64"}], "containerd.io.x86_64"=>[{:name=>"containerd.io", :epoch=>"0", :version=>"1.2.6", :release=>"3.3.el7", :arch=>"x86_64"}], "docker-ce"=>[{:name=>"docker-ce", :epoch=>"3", :version=>"19.03.5", :release=>"3.el7", :arch=>"x86_64"}], "docker-ce.x86_64"=>[{:name=>"docker-ce", :epoch=>"3", :version=>"19.03.5", :release=>"3.el7", :arch=>"x86_64"}], "docker-ce-cli"=>[{:name=>"docker-ce-cli", :epoch=>"1", :version=>"19.03.5", :release=>"3.el7", :arch=>"x86_64"}], "docker-ce-cli.x86_64"=>[{:name=>"docker-ce-cli", :epoch=>"1", :version=>"19.03.5", :release=>"3.el7", :arch=>"x86_64"}], "pcmhi"=>[{:name=>"pcmhi", :epoch=>"1", :version=>"3.6.0", :release=>"0", :arch=>"x86_64"}], "pcmhi.x86_64"=>[{:name=>"pcmhi", :epoch=>"1", :version=>"3.6.0", :release=>"0", :arch=>"x86_64"}], "puppet-agent"=>[{:name=>"puppet-agent", :epoch=>"0", :version=>"5.5.19", :release=>"1.el7", :arch=>"x86_64"}], "puppet-agent.x86_64"=>[{:name=>"puppet-agent", :epoch=>"0", :version=>"5.5.19", :release=>"1.el7", :arch=>"x86_64"}], "rhn-check"=>[{:name=>"rhn-check", :epoch=>"0", :version=>"2.0.2", :release=>"24.el7", :arch=>"x86_64"}], "rhn-check.x86_64"=>[{:name=>"rhn-check", :epoch=>"0", :version=>"2.0.2", :release=>"24.el7", :arch=>"x86_64"}], "rhn-client-tools"=>[{:name=>"rhn-client-tools", :epoch=>"0", :version=>"2.0.2", :release=>"24.el7", :arch=>"x86_64"}], "rhn-client-tools.x86_64"=>[{:name=>"rhn-client-tools", :epoch=>"0", :version=>"2.0.2", :release=>"24.el7", :arch=>"x86_64"}], "rhn-setup"=>[{:name=>"rhn-setup", :epoch=>"0", :version=>"2.0.2", :release=>"24.el7", :arch=>"x86_64"}], "rhn-setup.x86_64"=>[{:name=>"rhn-setup", :epoch=>"0", :version=>"2.0.2", :release=>"24.el7", :arch=>"x86_64"}], "subscription-manager"=>[{:name=>"subscription-manager", :epoch=>"0", :version=>"1.24.26", :release=>"1.el7", :arch=>"x86_64"}], "subscription-manager.x86_64"=>[{:name=>"subscription-manager", :epoch=>"0", :version=>"1.24.26", :release=>"1.el7", :arch=>"x86_64"}], "subscription-manager-rhsm"=>[{:name=>"subscription-manager-rhsm", :epoch=>"0", :version=>"1.24.26", :release=>"1.el7", :arch=>"x86_64"}], "subscription-manager-rhsm.x86_64"=>[{:name=>"subscription-manager-rhsm", :epoch=>"0", :version=>"1.24.26", :release=>"1.el7", :arch=>"x86_64"}], "subscription-manager-rhsm-certificates"=>[{:name=>"subscription-manager-rhsm-certificates", :epoch=>"0", :version=>"1.24.26", :release=>"1.el7", :arch=>"x86_64"}], "subscription-manager-rhsm-certificates.x86_64"=>[{:name=>"subscription-manager-rhsm-certificates", :epoch=>"0", :version=>"1.24.26", :release=>"1.el7", :arch=>"x86_64"}]} {code}

Add Comment

[Matt Schlosser (Jira)]

Custom Debug Output ( good/with our patch downgraded subscription-manager package ): {code:java}

Debug: Executing: '/bin/yum check-update' Debug: Puppet::Type::Package::ProviderYum: parse_updates body - note that the subscription manager warning is present on a bad run Debug: Puppet::Type::Package::ProviderYum: ----------------------------

Debug: Puppet::Type::Package::ProviderYum: containerd.io.x86_64                     1.2.6-3.3.el7         sbai    docker-ce.x86_64                     3:19.03.5-3.el7       sbai    docker-ce-cli.x86_64                     1:19.03.5-3.el7       sbai    pcmhi.x86_64                     1:3.6.0-0             pcmhi   puppet-agent.x86_64                     5.5.19-1.el7          puppet5 rhn-check.x86_64                     2.0.2-24.el7          rhel7   rhn-client-tools.x86_64                     2.0.2-24.el7          rhel7   rhn-setup.x86_64                     2.0.2-24.el7          rhel7   subscription-manager.x86_64                     1.24.26-1.el7         rhel7   subscription-manager-rhsm.x86_64                   1.24.26-1.el7         rhel7   subscription-manager-rhsm-certificates.x86_64      1.24.26-1.el7         rhel7   Debug: Puppet::Type::Package::ProviderYum: ---------------------------- <snip> Debug: Puppet::Type::Package::ProviderYum: update tuple - should be name|version|repo: ["pcmhi.x86_64", "1:3.6.0-0", "pcmhi"] Debug: Puppet::Type::Package::ProviderYum: update_to_hash {:name=>"pcmhi", :epoch=>"1", :version=>"3.6.0", :release=>"0", :arch=>"x86_64"} Debug: Puppet::Type::Package::ProviderYum: short_name pcmhi Debug: Puppet::Type::Package::ProviderYum: long_name pcmhi.x86_64 <snip> Debug: Puppet::Type::Package::ProviderYum: parse_updates output {"containerd.io"=>[{:name=>"containerd.io", :epoch=>"0", :version=>"1.2.6", :release=>"3.3.el7", :arch=>"x86_64"}], "containerd.io.x86_64"=>[{:name=>"containerd.io", :epoch=>"0", :version=>"1.2.6", :release=>"3.3.el7", :arch=>"x86_64"}], "docker-ce"=>[{:name=>"docker-ce", :epoch=>"3", :version=>"19.03.5", :release=>"3.el7", :arch=>"x86_64"}], "docker-ce.x86_64"=>[{:name=>"docker-ce", :epoch=>"3", :version=>"19.03.5", :release=>"3.el7", :arch=>"x86_64"}], "docker-ce-cli"=>[{:name=>"docker-ce-cli", :epoch=>"1", :version=>"19.03.5", :release=>"3.el7", :arch=>"x86_64"}], "docker-ce-cli.x86_64"=>[{:name=>"docker-ce-cli", :epoch=>"1", :version=>"19.03.5", :release=>"3.el7", :arch=>"x86_64"}], "pcmhi"=>[{:name=>"pcmhi", :epoch=>"1", :version=>"3.6.0", :release=>"0", :arch=>"x86_64"}], "pcmhi.x86_64"=>[{:name=>"pcmhi", :epoch=>"1", :version=>"3.6.0", :release=>"0", :arch=>"x86_64"}], "puppet-agent"=>[{:name=>"puppet-agent", :epoch=>"0", :version=>"5.5.19", :release=>"1.el7", :arch=>"x86_64"}], "puppet-agent.x86_64"=>[{:name=>"puppet-agent", :epoch=>"0", :version=>"5.5.19", :release=>"1.el7", :arch=>"x86_64"}], "rhn-check"=>[{:name=>"rhn-check", :epoch=>"0", :version=>"2.0.2", :release=>"24.el7", :arch=>"x86_64"}], "rhn-check.x86_64"=>[{:name=>"rhn-check", :epoch=>"0", :version=>"2.0.2", :release=>"24.el7", :arch=>"x86_64"}], "rhn-client-tools"=>[{:name=>"rhn-client-tools", :epoch=>"0", :version=>"2.0.2", :release=>"24.el7", :arch=>"x86_64"}], "rhn-client-tools.x86_64"=>[{:name=>"rhn-client-tools", :epoch=>"0", :version=>"2.0.2", :release=>"24.el7", :arch=>"x86_64"}], "rhn-setup"=>[{:name=>"rhn-setup", :epoch=>"0", :version=>"2.0.2", :release=>"24.el7", :arch=>"x86_64"}], "rhn-setup.x86_64"=>[{:name=>"rhn-setup", :epoch=>"0", :version=>"2.0.2", :release=>"24.el7", :arch=>"x86_64"}], "subscription-manager"=>[{:name=>"subscription-manager", :epoch=>"0", :version=>"1.24.26", :release=>"1.el7", :arch=>"x86_64"}], "subscription-manager.x86_64"=>[{:name=>"subscription-manager", :epoch=>"0", :version=>"1.24.26", :release=>"1.el7", :arch=>"x86_64"}], "subscription-manager-rhsm"=>[{:name=>"subscription-manager-rhsm", :epoch=>"0", :version=>"1.24.26", :release=>"1.el7", :arch=>"x86_64"}], "subscription-manager-rhsm.x86_64"=>[{:name=>"subscription-manager-rhsm", :epoch=>"0", :version=>"1.24.26", :release=>"1.el7", :arch=>"x86_64"}], "subscription-manager-rhsm-certificates"=>[{:name=>"subscription-manager-rhsm-certificates", :epoch=>"0", :version=>"1.24.26", :release=>"1.el7", :arch=>"x86_64"}], "subscription-manager-rhsm-certificates.x86_64"=>[{:name=>"subscription-manager-rhsm-certificates", :epoch=>"0", :version=>"1.24.26", :release=>"1.el7", :arch=>"x86_64"}]} {code}

Add Comment

[Matt Schlosser (Jira)]

PoC fix debug output for yum.rb:

Custom Debug Output (downgraded subscription-manager package):

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10432 RedHat RHBA-2020:1028 breaks yum.rb in yum provider for some systems

Change By: Josh Cooper Team: Night's Watch

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10432 RedHat RHBA-2020:1028 breaks yum.rb in yum provider for some systems

Change By: Mihai Buzgau Story Points: 1

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10432 RedHat RHBA-2020:1028 breaks yum.rb in yum provider for some systems

Change By: Mihai Buzgau Sprint: NW - 2020-04-29

Add Comment

[Gheorghe Popescu (Jira)]

Gheorghe Popescu assigned an issue to Gheorghe Popescu

Puppet / PUP-10432 RedHat RHBA-2020:1028 breaks yum.rb in yum provider for some systems

Change By: Gheorghe Popescu Assignee: Gheorghe Popescu

Add Comment

[Gheorghe Popescu (Jira)]

Gheorghe Popescu commented on PUP-10432

Re: RedHat RHBA-2020:1028 breaks yum.rb in yum provider for some systems PR for 5.5.x: https://github.com/puppetlabs/puppet/pull/8109

Add Comment

[Nick Walker (Jira)]

Nick Walker updated an issue

Puppet / PUP-10432

RedHat RHBA-2020:1028 breaks yum.rb in yum provider for some systems

Change By: Nick Walker Release Notes: Bug Fix Release Notes Summary: RedHat subscription Manager update causes ensure => latest to do nothing After upgrading RedHat subscription Manager to <version> using ensure => latest on the package provider on a RHEL agent would cause the package resource to never see possible updates.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10432 RedHat RHBA-2020:1028 breaks yum.rb in yum provider for some systems

Change By: Josh Cooper Fix Version/s: PUP 6.15.0

Add Comment

[Gabriel Nagy (Jira)]

Gabriel Nagy updated an issue

Puppet / PUP-10432 RedHat RHBA-2020:1028 breaks yum.rb in yum provider for some systems

Change By: Gabriel Nagy Fix Version/s: PUP 5.5.20

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Puppet / PUP-10432 RedHat RHBA-2020:1028 breaks yum.rb in yum provider for some systems

Change By: Claire Cadman Labels: doc_reviewed

Add Comment