Jira (PUP-10418) Unify service return values

18 views
Skip to first unread message

Josh Cooper (Jira)

unread,
Apr 9, 2020, 12:13:03 PM4/9/20
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Bug PUP-10418
Unify service return values
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2020/04/09 9:12 AM
Fix Versions: PUP 6.15.0
Priority: Normal Normal
Reporter: Josh Cooper

The get|post|put|* REST API methods aren't consistent about return values. For example put can return a boolean, the stringified response body or the response object. It would be good to make those consistent. Also it would be good to always return the response so that the caller can elect to resubmit the request with different parameters if needed. If the method also returns an entity, then have the method return an array containing [response, entity].
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Josh Cooper (Jira)

unread,
Apr 9, 2020, 2:36:03 PM4/9/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Coremunity Hopper

Melissa Stone (Jira)

unread,
Apr 13, 2020, 12:59:03 PM4/13/20
to puppe...@googlegroups.com
Melissa Stone updated an issue
Change By: Melissa Stone
Sprint: Coremunity Hopper Platform Core KANBAN

Melissa Stone (Jira)

unread,
Apr 13, 2020, 12:59:03 PM4/13/20
to puppe...@googlegroups.com
Melissa Stone assigned an issue to Melissa Stone
Change By: Melissa Stone
Assignee: Melissa Stone

Josh Cooper (Jira)

unread,
Apr 15, 2020, 7:50:03 PM4/15/20
to puppe...@googlegroups.com

Melissa Stone (Jira)

unread,
Apr 16, 2020, 3:44:03 PM4/16/20
to puppe...@googlegroups.com
Melissa Stone updated an issue
Change By: Melissa Stone
Release Notes: Not Needed

Melissa Stone (Jira)

unread,
Apr 16, 2020, 3:44:03 PM4/16/20
to puppe...@googlegroups.com

This has passed ci as a part of puppet-agent 6.14.0.281.g711c1b9a

Melissa Stone (Jira)

unread,
Apr 16, 2020, 3:45:03 PM4/16/20
to puppe...@googlegroups.com
Melissa Stone updated an issue
Change By: Melissa Stone
Release Notes: Not Needed Enhancement
Release Notes Summary: Change the return values of the http client service methods to consistently return the request response in addition to previous return values

Claire Cadman (Jira)

unread,
Apr 27, 2020, 6:45:03 AM4/27/20
to puppe...@googlegroups.com
Claire Cadman updated an issue
Change By: Claire Cadman
Labels: doc_reviewed
Reply all
Reply to author
Forward
0 new messages