Jira (PUP-10390) Ruby file gets loaded twice

Luchian Nemes (Jira)

unread,

Mar 27, 2020, 4:58:03 AM3/27/20

to puppe...@googlegroups.com

Luchian Nemes created an issue

Puppet /

PUP-10390

Ruby file gets loaded twice

Issue Type:	Improvement
Assignee:	Unassigned
Created:	2020/03/27 1:57 AM
Priority:	Low
Reporter:	Luchian Nemes

The provider/package/gem.rb file gets loaded twice. This prevents us from having constant variables without getting the following warnings at each run:
/Users/luchi/repos/puppet/lib/puppet/provider/package/gem.rb:21: warning: already initialized constant MY_CONSTANT_VARIABLE
/Users/luchi/repos/puppet/lib/puppet/provider/package/gem.rb:21: warning: previous definition of MY_CONSTANT_VARIABLE was here

This happens due to the require done in provider/package/puppet_gem.rb and then loaded again in util/autoload.rb. This can be seen by putting a 'puts(caller)' in provider/package/gem.rb.

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

Luchian Nemes (Jira)

unread,

Mar 27, 2020, 5:05:05 AM3/27/20

to puppe...@googlegroups.com

Luchian Nemes updated an issue

Puppet /

PUP-10390

Ruby file gets loaded twice

Change By:	Luchian Nemes

The [provider/package/gem.rb|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/package/gem.rb] file gets loaded twice. This prevents us from having constant variables without getting the following warnings at each run:
*/Users/luchi/repos/puppet/lib/puppet/provider/package/gem.rb:21: warning: already initialized constant MY_CONSTANT_VARIABLE*
*/Users/luchi/repos/puppet/lib/puppet/provider/package/gem.rb:21: warning: previous definition of MY_CONSTANT_VARIABLE was here*

This happens due to the require done in [provider/package/puppet_gem.rb|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/package/puppet_gem.rb] and then loaded again in [util/autoload.rb|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/autoload.rb]. This can be seen by putting a 'puts(caller)' in [provider/package/gem.rb|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/package/gem.rb].

After fixing the issue, a refactoring should be done in [provider/package/gem.rb|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/package/gem.rb] to use (for better code readability):
|GEM_VERSION = Puppet::Util::Package::Version::Gem|
|GEM_VERSION_RANGE = Puppet::Util::Package::Version::Range|