Jira (PUP-10370) Compress reports sent using "http" report processor

6 views
Skip to first unread message

Josh Cooper (Jira)

unread,
Mar 13, 2020, 9:24:03 PM3/13/20
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Improvement PUP-10370
Compress reports sent using "http" report processor
Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 2020/03/13 6:23 PM
Priority: Normal Normal
Reporter: Josh Cooper

The "http" report processor does not specify the "compress" option when posting the report, so puppetserver does not compress it. The processor should specify that option (maybe conditional based on an http_compression property), so that reports are compressed between puppetserver and the HTTP(S) server. The puppetdb terminus already does this when submitting reports/catalogs/facts/etc to puppetdb. See https://github.com/puppetlabs/puppetdb/blob/1262e5f1165c00cb22b51ab5fab5649bda759a64/puppet/lib/puppet/util/puppetdb/command.rb#L68

For this ticket, just add :compress => :gzip to the options passed to client.post in lib/puppet/reports/http.rb.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Josh Cooper (Jira)

unread,
Mar 13, 2020, 9:25:03 PM3/13/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Mar 13, 2020, 9:32:03 PM3/13/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
The "http" report processor does not specify the "compress" option when posting the report, so puppetserver does not compress it. The processor should specify that option (maybe conditional based on an http_compression property), so that reports are compressed between puppetserver and the HTTP(S) server. The puppetdb terminus already does this when submitting reports/catalogs/facts/etc to puppetdb. See https://github.com/puppetlabs/puppetdb/blob/1262e5f1165c00cb22b51ab5fab5649bda759a64/puppet/lib/puppet/util/puppetdb/command.rb#L68

For this ticket, just add {{:compress => :gzip}} to the options passed to {{client.post}} in {{lib/puppet/reports/http.rb}}.

Reports are highly compressible. An empty catalog compresses from 6512 bytes to 1119 bytes, about 1/6th the size. A more typical catalog compresses from 66021785 bytes to 4721897, which is about 1/13th the size.
Reply all
Reply to author
Forward
0 new messages