Jira (PUP-10366) 5.5.17 agents fail on interval runs

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10366 5.5.17 agents fail on interval runs Change By: Josh Cooper Affects Version/s: PUP 5.5.17 Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Josh Cooper (Jira)]

Josh Cooper moved an issue

Puppet / PUP-10366 5.5.17 agents fail on interval runs

Change By: Josh Cooper Key: PA PUP - 3167 10366 Project: Puppet Agent

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10366 5.5.17 agents fail on interval runs

Change By: Josh Cooper Fix Version/s: PUP 5.5.19

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10366 5.5.17 agents fail on interval runs

Change By: Josh Cooper Team: Coremunity

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10366

Re: 5.5.17 agents fail on interval runs This is reproducible using 5.5.17 using: # puppet agent --no-daemonize --verbose --server localhost --onetime Warning: Unable to fetch my node definition, but the agent run will continue: Warning: Failed to open TCP connection to localhost:8140 (Connection refused - connect(2) for "localhost" port 8140) Info: Retrieving pluginfacts Error: /File[/opt/puppetlabs/puppet/cache/facts.d]: Failed to generate additional resources using 'eval_generate': Failed to open TCP connection to localhost:8140 (Connection refused - connect(2) for "localhost" port 8140) Error: /File[/opt/puppetlabs/puppet/cache/facts.d]: Could not evaluate: Could not retrieve file metadata for puppet:///pluginfacts: Failed to open TCP connection to localhost:8140 (Connection refused - connect(2) for "localhost" port 8140) Info: Retrieving plugin Error: /File[/opt/puppetlabs/puppet/cache/lib]: Failed to generate additional resources using 'eval_generate': Failed to open TCP connection to localhost:8140 (Connection refused - connect(2) for "localhost" port 8140) Error: /File[/opt/puppetlabs/puppet/cache/lib]: Could not evaluate: Could not retrieve file metadata for puppet:///plugins: Failed to open TCP connection to localhost:8140 (Connection refused - connect(2) for "localhost" port 8140) Error: Could not retrieve catalog from remote server: Failed to open TCP connection to localhost:8140 (Connection refused - connect(2) for "localhost" port 8140) Error: Could not retrieve catalog; skipping run Error: Could not send report: Failed to open TCP connection to localhost:8140 (Connection refused - connect(2) for "localhost" port 8140) The problem is that client.run can return nil which is later passed to exit causing the no implicit conversion from nil to integer (TypeError).

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10366

Re: 5.5.17 agents fail on interval runs

There are a few other places in that code where the same thing can happen.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10366

5.5.17 agents fail on interval runs

Change By: Josh Cooper Sprint: Coremunity Hopper

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10366 5.5.17 agents fail on interval runs

Change By: Josh Cooper Fix Version/s: PUP 6.15.0

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10366 5.5.17 agents fail on interval runs

Change By: Mihai Buzgau Team: Coremunity Night's Watch

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10366 5.5.17 agents fail on interval runs

Change By: Mihai Buzgau Sprint: Coremunity Hopper PR - Triage

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10366

Re: 5.5.17 agents fail on interval runs The error occurs because we end up calling `exit(nil)` in https://github.com/puppetlabs/puppet/blob/1996d1d94a54d83e1098454c4bcd660ccaca2441/lib/puppet/agent.rb#L98. That's because the block we yield to doesn't always return a value such as https://github.com/puppetlabs/puppet/blob/1996d1d94a54d83e1098454c4bcd660ccaca2441/lib/puppet/agent.rb#L64. Also need to confirm that https://github.com/puppetlabs/puppet/blob/1996d1d94a54d83e1098454c4bcd660ccaca2441/lib/puppet/agent.rb#L59 always returns an integer value too. For example in https://github.com/puppetlabs/puppet/blob/1996d1d94a54d83e1098454c4bcd660ccaca2441/lib/puppet/configurer.rb#L234 we return nil if the configurer run didn't complete.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10366

5.5.17 agents fail on interval runs

Change By: Josh Cooper Fix Version/s: PUP 5.5.19 Fix Version/s: PUP 5.5.20

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10366 5.5.17 agents fail on interval runs

Change By: Mihai Buzgau Sprint: PR NW - Triage 2020-04-15

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10366 5.5.17 agents fail on interval runs

Change By: Mihai Buzgau Story Points: 2

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu assigned an issue to Ciprian Badescu

Puppet / PUP-10366 5.5.17 agents fail on interval runs

Change By: Ciprian Badescu Assignee: Ciprian Badescu

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10366

Re: 5.5.17 agents fail on interval runs Merged to 5.5.x in https://github.com/puppetlabs/puppet/commit/20bea7684a81265a221f0974c4f21469b3b8296b

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10366

5.5.17 agents fail on interval runs

Change By: Mihai Buzgau Sprint: NW - 2020-04-15 , NW - 2020-04-29

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Puppet / PUP-10366 5.5.17 agents fail on interval runs

Change By: Claire Cadman Labels: doc_reviewed jira_escalated

Add Comment