Jira (FACT-2438) Remove methods from facter 4 api which are private in facter 3

[Andrei Filipovici (Jira)]

Andrei Filipovici updated an issue

Facter / FACT-2438 Remove methods from facter 4 api which are private in facter 3 Change By: Andrei Filipovici Summary: Remove unnecessary Execution module methods from Resolution facter 4 api which are private in facter 3 Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Andrei Filipovici (Jira)]

Andrei Filipovici updated an issue

Facter / FACT-2438 Remove methods from facter 4 api which are private in facter 3 Change By: Andrei Filipovici

The Exception module is extended by the Resolution class. Only the which and exec methods are needed, to maintain compatibility with Facter 3.x. For this, a new module with just the two methods from Execution will be created and included in the Resolution and Aggregate classes. weight on resolution is private in facter 3

Add Comment

[Andrei Filipovici (Jira)]

Andrei Filipovici updated an issue

Facter / FACT-2438 Remove methods from facter 4 api which are private in facter 3 Change By: Andrei Filipovici

The Exception module is extended by the Resolution class. Only the which and exec methods are needed, to maintain compatibility with Facter 3.x. For this, a new module with just the two methods from Execution will be created and included in the Resolution and Aggregate classes.

flush, weight on resolution is are private in facter 3

Add Comment

[Andrei Filipovici (Jira)]

Andrei Filipovici updated an issue

Facter / FACT-2438 Remove methods from facter 4 api which are private in facter 3 Change By: Andrei Filipovici

The Exception module is extended by the Resolution class. Only the which and exec methods are needed, to maintain compatibility with Facter 3.x. For this, a new module with just the two methods from Execution will be created and included in the Resolution and Aggregate classes.

value, name, execute, flush, weight on resolution are private in facter 3

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Facter / FACT-2438 Remove methods from facter 4 api which are private in facter 3

Change By: Mihai Buzgau Sprint: ready for triage

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie commented on FACT-2438

Re: Remove methods from facter 4 api which are private in facter 3 We should check if it makes sense to make the methods private.

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

Facter / FACT-2438

Remove methods from facter 4 api which are private in facter 3

Change By: Bogdan Irimie Story Points: 2

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

Facter / FACT-2438 Remove methods from facter 4 api which are private in facter 3

Change By: Bogdan Irimie Sprint: ready for triage ghost-23.09

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

Facter / FACT-2438 Remove methods from facter 4 api which are private in facter 3

Change By: Bogdan Irimie Sprint: ghost-23.09 , ready for triage 2

Add Comment

[Andrei Filipovici (Jira)]

Andrei Filipovici assigned an issue to Andrei Filipovici

Facter / FACT-2438 Remove methods from facter 4 api which are private in facter 3

Change By: Andrei Filipovici Assignee: Andrei Filipovici

Add Comment

[Andrei Filipovici (Jira)]

Andrei Filipovici updated an issue

Facter / FACT-2438 Remove methods from facter 4 api which are private in facter 3 Change By: Andrei Filipovici

The Exception Execution module is extended by the Resolution class. Only the which and exec methods are needed, to maintain compatibility with Facter 3.x. For this, a new module with just the two methods from Execution will be created and included in the Resolution and Aggregate classes. value, name, execute, flush, weight on resolution are private in facter 3

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

Facter / FACT-2438 Remove methods from facter 4 api which are private in facter 3

Change By: Bogdan Irimie Sprint: ghost-23.09, ghost-30.09 , ready for triage 2

Add Comment

[Andrei Filipovici (Jira)]

Andrei Filipovici commented on FACT-2438

Re: Remove methods from facter 4 api which are private in facter 3 Trying to hide some of the Execution module functions, break the LegacyFacter::Util::Config unit tests, because they use the with_env function. The same thing is valid for the Fact, Resolution and Aggregate classes. If we use access proxies we need to make sure that methods like define_resolution return the proxy. All of this makes the code harder to understand and there's little advantage added.

Add Comment