Jira (FACT-2419) Change facts to new module structure that respects rubocop guidelines

3 views
Skip to first unread message

Bogdan Irimie (Jira)

unread,
Feb 28, 2020, 5:21:04 AM2/28/20
to puppe...@googlegroups.com
Bogdan Irimie created an issue
 
Facter / Task FACT-2419
Change facts to new module structure that respects rubocop guidelines
Issue Type: Task Task
Assignee: Unassigned
Created: 2020/02/28 2:20 AM
Priority: Normal Normal
Reporter: Bogdan Irimie

 Current implementation

module Facter
  module El
    class DmiBiosReleaseDate
      FACT_NAME = 'dmi.bios.release_date'
 
      def call_the_resolver
        fact_value = Resolvers::Linux::DmiBios.resolve(:bios_date)
        ResolvedFact.new(FACT_NAME, fact_value)
      end
    end
  end
end

 

Suggested implementation

module Facter
  module El
    module Dmi
      module Bios
        class ReleaseDate
          FACT_NAME = 'dmi.bios.release_date'
 
          def call_the_resolver
            fact_value = Resolvers::Linux::DmiBios.resolve(:bios_date)
            ResolvedFact.new(FACT_NAME, fact_value)
          end
        end
      end
    end
  end
end

 

 

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Bogdan Irimie (Jira)

unread,
Feb 28, 2020, 5:39:05 AM2/28/20
to puppe...@googlegroups.com

Oana Tanasoiu (Jira)

unread,
Feb 28, 2020, 8:47:04 AM2/28/20
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages