Jira (PDB-4655) Audit error handling/shutdown behavior when PDB is broadcasting

Rob Browning (Jira)

unread,

Apr 27, 2020, 12:33:03 PM4/27/20

to puppe...@googlegroups.com

Rob Browning updated an issue

PuppetDB /

PDB-4655

Audit error handling/shutdown behavior when PDB is broadcasting

Change By:	Rob Browning
Summary:	Audit error handling/shutdown behavior when PDB is in broadcast mode broadcasting

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

Zachary Kent (Jira)

unread,

Jun 9, 2020, 2:29:03 PM6/9/20

to puppe...@googlegroups.com

Zachary Kent updated an issue

PuppetDB /

PDB-4655

Audit error handling/shutdown behavior when PDB is broadcasting

Change By:	Zachary Kent

When running in broadcast mode make sure that PDB properly closes all connections to the write dbs on an error. Could be a good case to look into [Murphy|https://gitlab.com/clj-murphy/murphy] to make sure we get the error handling right if we throw again while shutting down.

Specifically look into init behavior of PuppetDBCommandDispatcher service. An error during service init can cause resources in the context to be nil when they're used later in another service's start method. To fix this properly we would need to update trapperkeeper's behavior where it can call start methods after a failure in init. As a work around without the tk changes we could move any setup code out of our init method in the command dispatch service.