Jira (PUP-10286) When a site has no active connections, it should be removed from the pool.

[Melissa Stone (JIRA)]

Melissa Stone created an issue

Puppet / PUP-10286 When a site has no active connections, it should be removed from the pool. Issue Type: Task Assignee: Unassigned Created: 2020/02/07 3:01 PM Priority: Normal Reporter: Melissa Stone Spurred from conversation in https://github.com/puppetlabs/puppet/pull/7968 when closing a connection, if a site has no sessions associated with it, the site should be removed from the pool. pool with an active connectin: > pool => #<Puppet::Network::HTTP::Pool:0x00007f84fdd21110 @factory=#<Puppet::Network::HTTP::Factory:0x00007f84fdd210c0>, @keepalive_timeout=15, @pool= {#<Puppet::Network::HTTP::Site:0x00007f84fdd21228 @host="rubygems.org", @port=443, @scheme="https">=> [#<Puppet::Network::HTTP::Session:0x00007f84fdd20e40 @connection=#<Net::HTTP https://rubygems.org:443:80 open=true>, @expiration_time=2020-02-07 14:58:31 -0800>]}> versus pool after the only connection has been closed: > pool => #<Puppet::Network::HTTP::Pool:0x00007f84fdd21110 @factory=#<Puppet::Network::HTTP::Factory:0x00007f84fdd210c0>, @keepalive_timeout=15, @pool= {#<Puppet::Network::HTTP::Site:0x00007f84fdd21228 @host="rubygems.org", @port=443, @scheme="https">=>[]}> notice to access the connections, we need to call pool.pool, which is confusing. Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-10286 When a site has no active connections, it should be removed from the pool.

Change By: Josh Cooper Team: Coremunity

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-10286 When a site has no active connections, it should be removed from the pool.

Change By: Josh Cooper Fix Version/s: PUP 6.14.0

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-10286 When a site has no active connections, it should be removed from the pool.

Change By: Josh Cooper Sprint: Coremunity Hopper

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper assigned an issue to Josh Cooper

Puppet / PUP-10286 When a site has no active connections, it should be removed from the pool.

Change By: Josh Cooper Assignee: Josh Cooper

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-10286 When a site has no active connections, it should be removed from the pool.

Change By: Josh Cooper Sprint: Coremunity Hopper Platform Core KANBAN

Add Comment

[Melissa Stone (JIRA)]

Melissa Stone commented on PUP-10286

Re: When a site has no active connections, it should be removed from the pool. Merged into master with https://github.com/puppetlabs/puppet/commit/5727d31e089b5d701f399fda52aec52533b197c1

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-10286

When a site has no active connections, it should be removed from the pool.

Change By: Josh Cooper Release Notes Summary: Very minor reduction in memory usage when the last connection from the http pool is borrowed and never returned. Release Notes: Bug Fix

Add Comment

[Melissa Stone (JIRA)]

Melissa Stone commented on PUP-10286

Re: When a site has no active connections, it should be removed from the pool. This has passed ci as a part of puppet-agent 6.13.0.51.gf3fde108

Add Comment