Jira (PUP-10241) Ensure XML plist data has UTF-8 encoding before parsing

[Gabriel Nagy (JIRA)]

Gabriel Nagy created an issue

Puppet / PUP-10241 Ensure XML plist data has UTF-8 encoding before parsing Issue Type: Improvement Assignee: Gabriel Nagy Created: 2020/01/20 5:30 AM Priority: Normal Reporter: Gabriel Nagy When creating a user/group resource on macOS Catalina, the directoryservice provider would fail with the following: Debug: Failed with ArgumentError on : #<ArgumentError: invalid byte sequence in US-ASCII> Error: Could not prefetch user provider 'directoryservice': undefined method `each' for nil:NilClass This issue is caused by the Puppet::Util::Plist.parse_plist method receiving XML plist_data in ASCII instead of UTF-8 encoding (see https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/user/directoryservice.rb#L95 for an example). XML plists begin with <?xml version="1.0" encoding="UTF-8"?>. Based on this, we can force the encoding of the plist data to be UTF-8. We do this conditionally, since the parse_plist method can also be called with plist data in binary format. This issue seems to have been present from the beginning, but luckily no non-ASCII plist data snuck through until now. Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Mihai Buzgau (JIRA)]

Mihai Buzgau updated an issue

Puppet / PUP-10241 Ensure XML plist data has UTF-8 encoding before parsing

Change By: Mihai Buzgau Sprint: NW - 2020-01-22 , NW - 2020-02-05

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-10241

Re: Ensure XML plist data has UTF-8 encoding before parsing Merged to 5.5.x in https://github.com/puppetlabs/puppet/commit/65eb24c2e948199e8b45b983cf55ba90aae68ce3

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-10241

Ensure XML plist data has UTF-8 encoding before parsing

Change By: Josh Cooper Fix Version/s: PUP 6.4.6 Fix Version/s: PUP 5.5.19 Fix Version/s: PUP 6.13.0

Add Comment

[Gabriel Nagy (JIRA)]

Gabriel Nagy updated an issue

Puppet / PUP-10241 Ensure XML plist data has UTF-8 encoding before parsing

Change By: Gabriel Nagy Release Notes Summary: Fixed an issue where Puppet would try to parse an XML property list file as ASCII instead of UTF-8. Release Notes: Bug Fix

Add Comment

[Kate Medred (JIRA)]

Kate Medred updated an issue

Puppet / PUP-10241 Ensure XML plist data has UTF-8 encoding before parsing

Change By: Kate Medred Labels: resolved-issue-added

Add Comment