Jira (PUP-10240) Puppet gem has no/missing development/test gems

28 views
Skip to first unread message

Tim Meusel (JIRA)

unread,
Jan 19, 2020, 1:36:05 PM1/19/20
to puppe...@googlegroups.com
Tim Meusel created an issue
 
Puppet / Bug PUP-10240
Puppet gem has no/missing development/test gems
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2020/01/19 10:35 AM
Priority: Normal Normal
Reporter: Tim Meusel

Hi,

I took a look at the puppet gem dependencies for the latest release:

https://rubygems.org/gems/puppet/versions/6.12.0

It lists a few runtime dependencies, but no additional dependencies for development/test. Could you add gems required to execute the test suite as well?

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Jorie Tappa (JIRA)

unread,
Jan 21, 2020, 4:43:03 PM1/21/20
to puppe...@googlegroups.com
Jorie Tappa commented on Bug PUP-10240
 
Re: Puppet gem has no/missing development/test gems

Hi Tim Meusel you can view our development and test gem groups directly in our Puppet repo, if that's helpful here: https://github.com/puppetlabs/puppet/blob/master/Gemfile#L38-L58 

What workflow are you using that would make having them in the puppet gem itself easier for you? Right now we don't have a good way to include these items there.

Jorie Tappa (JIRA)

unread,
Jan 21, 2020, 4:46:04 PM1/21/20
to puppe...@googlegroups.com

Tim Meusel (JIRA)

unread,
Jan 21, 2020, 5:35:04 PM1/21/20
to puppe...@googlegroups.com
Tim Meusel commented on Bug PUP-10240
 
Re: Puppet gem has no/missing development/test gems

Hi Jorie Tappa!
I'm building the official Arch Linux packages for Puppet tools. That includes r10k, pdk and Puppet. The abstract workflow for Arch packages looks like this:

  • Setup a minimal Arch container
  • Download the release. e.g. a git tag or a tar ball from http://downloads.puppet.com/
  • Install all dependencies required to run tests + to built it via native Arch packages
  • Run the tests
  • "build" the software

specific for Puppet: At the moment we download the release from https://downloads.puppetlabs.com/, verify the signature and try to install required dependencies. Since puppet is published as a gem, I went the usual way for gems -> checking required depdencies on rubygems.org / in the gemspec file. Most projects I work with define runtime + test dependencies in the gemspec. Stuff that's nice for development is defined in a Gemfile.

Josh Cooper (JIRA)

unread,
Jan 22, 2020, 1:27:04 AM1/22/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Change By: Josh Cooper
Fix Version/s: PUP 6.13.0

Josh Cooper (JIRA)

unread,
Jan 22, 2020, 1:28:03 AM1/22/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Platform Core KANBAN

Josh Cooper (JIRA)

unread,
Jan 22, 2020, 12:35:04 PM1/22/20
to puppe...@googlegroups.com
Josh Cooper assigned an issue to Josh Cooper
Change By: Josh Cooper
Assignee: Josh Cooper

Josh Cooper (JIRA)

unread,
Feb 7, 2020, 8:20:04 PM2/7/20
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-10240
 
Re: Puppet gem has no/missing development/test gems

I thought this would be a simple change and submitted a PR but ran into some weird development dependency issue with rspec-expectations... Going to have to come back to this later.

Josh Cooper (JIRA)

unread,
Feb 7, 2020, 8:20:04 PM2/7/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 6.13.0
Fix Version/s: PUP 6.14.0

Josh Cooper (Jira)

unread,
Mar 2, 2020, 1:19:03 PM3/2/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 6.14.0
Fix Version/s: PUP 6.y
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Josh Cooper (Jira)

unread,
Mar 2, 2020, 2:23:03 PM3/2/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Platform Core KANBAN Coremunity Hopper

Josh Cooper (Jira)

unread,
Mar 2, 2020, 2:23:03 PM3/2/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Coremunity Hopper

Josh Cooper (Jira)

unread,
Jan 13, 2021, 2:45:03 PM1/13/21
to puppe...@googlegroups.com
Josh Cooper assigned an issue to Unassigned
Change By: Josh Cooper
Assignee: Josh Cooper

Josh Cooper (Jira)

unread,
Sep 3, 2021, 1:36:03 PM9/3/21
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-10240
 
Re: Puppet gem has no/missing development/test gems

It seems that the current best practice is to list development dependencies in the Gemfile not the gemspec. For example, https://github.com/ruby/racc/commit/72c3390fdaa294a85ef90db333e21b62b9623759. So I'm inclined to close this as won't fix. Thoughts Tim Meusel?

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Tim Meusel (Jira)

unread,
Sep 3, 2021, 1:44:02 PM9/3/21
to puppe...@googlegroups.com
Tim Meusel commented on Bug PUP-10240

yes that's fine. as long as all of them are documented in the Gemfile or gemspec that's fine.

Reply all
Reply to author
Forward
0 new messages