| Hi Gabriel Nagy, Good news. I've tested changing line 207 in adsi.rb to the upcase syntax provided by you as well as the casecmp syntax suggested by Josh Cooper and both versions work. I've also tested modifying the comment and the groups properties.
One thing I noticed when testing the group change in noop mode is the output isn't correct. The output returned contains references to the groups as defined in the manifest as well as the current built-in group name.
Notice: Compiled catalog for member01.domain.com in environment production in 0.02 seconds
Notice: /Stage[main]/Main/User[test_user]/groups: current_value BUILTIN\Administrators, should be 'Administrators,BUILTIN\Administrators,Remote Management Users' (noop)
Notice: Class[Main]: Would have triggered 'refresh' from 1 event
Notice: Stage[main]: Would have triggered 'refresh' from 1 event
Notice: Applied catalog in 0.06 seconds
When running without --noop the output is as expected:
Notice: Compiled catalog for member01.domain.com in environment production in 0.03 seconds
Notice: /Stage[main]/Main/User[test_user]/groups: groups changed BUILTIN\Administrators to ['BUILTIN\Administrators', 'BUILTIN\Remote Management Users']
Notice: Applied catalog in 0.14 seconds
It looks like noop mode is not recognizing that BUILTIN\Group matches Group in the manifest. I know this is cosmetic so I'm not sure if it's worth the effort to correct. Thanks,
Steve |
