Jira (PUP-10213) Do not create exceptions for stacktrace information when we know we won't use that information

[Justin Stoller (JIRA)]

Justin Stoller created an issue

Puppet / PUP-10213 Do not create exceptions for stacktrace information when we know we won't use that information Issue Type: Improvement Assignee: Unassigned Created: 2020/01/02 1:23 PM Priority: Normal Reporter: Justin Stoller Currently when the evaluator runs across a valid warning it will create an exception in the `optionally_fail` method. That exception is passed into the error handling code (acceptor) that later decides if the issue warrants erring out, printing a warning with a stacktrace, printing a warning without a stacktrace, or ignoring. Creating exceptions/backtraces are expensive in some environments, we should only create them when we know we will print the information they contain. There is no use in creating them when we know we will not use them. It should be possible to check the validator/acceptor from optionally_fail and only create the exception when the correct conditions hold. Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Justin Stoller (JIRA)]

Justin Stoller assigned an issue to Justin Stoller

Puppet / PUP-10213 Do not create exceptions for stacktrace information when we know we won't use that information

Change By: Justin Stoller Assignee: Justin Stoller

Add Comment

[Maggie Dreyer (JIRA)]

Maggie Dreyer updated an issue

Puppet / PUP-10213 Do not create exceptions for stacktrace information when we know we won't use that information

Change By: Maggie Dreyer Team: Froyo

Add Comment

[Justin Stoller (JIRA)]

Justin Stoller updated an issue

Puppet / PUP-10213 Do not create exceptions for stacktrace information when we know we won't use that information

Change By: Justin Stoller Release Notes Summary: Some compilation warnings will now take less time to compute. Release Notes: Enhancement

Add Comment

[Justin Stoller (JIRA)]

Justin Stoller updated an issue

Puppet / PUP-10213 Do not create exceptions for stacktrace information when we know we won't use that information

Change By: Justin Stoller Fix Version/s: PUP 6.12.0 Fix Version/s: PUP 6.4.5 Fix Version/s: PUP 5.5.18

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-10213

Re: Do not create exceptions for stacktrace information when we know we won't use that information Merged to 5.5.x in https://github.com/puppetlabs/puppet/commit/98418778127368c1f341745b72dfe83abde887b6

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-10213

Re: Do not create exceptions for stacktrace information when we know we won't use that information

Passed CI in 98418778

Add Comment

[Jean Bond (JIRA)]

Jean Bond updated an issue

Puppet / PUP-10213

Do not create exceptions for stacktrace information when we know we won't use that information

Change By: Jean Bond Release Notes Summary: Some This release includes improvements to the evaluator, meaning some compilation warnings will now take less time to compute.

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-10213

Re: Do not create exceptions for stacktrace information when we know we won't use that information Passed 6.4.x CI in 0cef459424

Add Comment

[Kate Medred (JIRA)]

Kate Medred updated an issue

Puppet / PUP-10213

Do not create exceptions for stacktrace information when we know we won't use that information

Change By: Kate Medred Release note: Do not create exceptions for stacktrace information Currently , when the evaluator runs across a valid warning it will create an exception in the optionally_fail method. That exception is passed into the error handling code (acceptor) that later decides if the issue warrants erring out, printing a warning with a stacktrace, printing a warning without a stacktrace, or ignoring. There is no use in creating exceptions when it is known they will not be used. It should be possible to check the validator/acceptor from optionally_fail and only create the exception when the correct conditions hold. ------ Original note: Currently when the evaluator runs across a valid warning it will create an exception in the `optionally_fail` method. That exception is passed into the error handling code (acceptor) that later decides if the issue warrants erring out, printing a warning with a stacktrace, printing a warning without a stacktrace, or ignoring.

Creating exceptions/backtraces are expensive in some environments, we should only create them when we know we will print the information they contain. There is no use in creating them when we know we will not use them. It should be possible to check the validator/acceptor from optionally_fail and only create the exception when the correct conditions hold.

Add Comment