Jira (PUP-10170) Do not store Puppet stack within Ruby stack / Backport master work to 5.5.x

[Maggie Dreyer (JIRA)]

Maggie Dreyer updated an issue

Puppet / PUP-10170 Do not store Puppet stack within Ruby stack / Backport master work to 5.5.x Change By: Maggie Dreyer Team: Server Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Maggie Dreyer (JIRA)]

Maggie Dreyer commented on PUP-10170

Re: Do not store Puppet stack within Ruby stack / Backport master work to 5.5.x Are there release notes that should be added to this?

Add Comment

[Justin Stoller (JIRA)]

Justin Stoller updated an issue

Puppet / PUP-10170

Do not store Puppet stack within Ruby stack / Backport master work to 5.5.x

I made a release here to describe the improvement backported. I figured I'd write about the change in output once we land PUP-10150 and do so there (since that ticket will be applicable to the release notes for both 5.5.x & 6.x. Lemme know if that's wrong. Change By: Justin Stoller Release Notes Summary: Puppet manifests that make use of stdlib's `deprecation` function, use the pseudo keywords `break`, `return`, and `next`, experience serialization warnings, or have custom Ruby code that makes use of the `PuppetStack.top_of_stack` function should see a marked increase in performance. Release Notes: Enhancement

Add Comment

[Dorin Pleava (JIRA)]

Dorin Pleava updated an issue

Puppet / PUP-10170 Do not store Puppet stack within Ruby stack / Backport master work to 5.5.x

Change By: Dorin Pleava Fix Version/s: PUP 6.12.0 Fix Version/s: PUP 6.4.5

Add Comment

[Jean Bond (JIRA)]

Jean Bond commented on PUP-10170

Re: Do not store Puppet stack within Ruby stack / Backport master work to 5.5.x Justin Stoller, is PUP-10213 also related to this work? I'm thinking of making one release note to rule them all.

Add Comment

[Justin Stoller (JIRA)]

Justin Stoller commented on PUP-10170

Re: Do not store Puppet stack within Ruby stack / Backport master work to 5.5.x

Yes, this ticket was a performance improvement that has already gone out in the last Platform release (6.11?). Now it will also be going out in 5.5.x and 6.4.x. It caused a regression in stacktrace printing which will be fixed in 6.12, along with that fix we introduced the new feature of the "puppet_trace" setting. 5.5.x & 6.4.x won't see the regression but will get the new "puppet_trace" output option.

Add Comment

[Kate Medred (JIRA)]

Kate Medred updated an issue

Puppet / PUP-10170

Do not store Puppet stack within Ruby stack / Backport master work to 5.5.x

Change By: Kate Medred Labels: resolved-issue-added

Add Comment

[Kate Medred (JIRA)]

Kate Medred updated an issue

Puppet / PUP-10170 Do not store Puppet stack within Ruby stack / Backport master work to 5.5.x

Change By: Kate Medred Release Notes Summary:

Puppet manifests that make use of stdlib's `deprecation` function, use the pseudo keywords `break`, `return`, and `next`, experience serialization warnings, or have custom Ruby code that makes use of the `PuppetStack.top_of_stack` function should see a marked increase in performance.

--- Release note: Performance of manifests that use the `PuppetStack.top_of_stack` function have been greatly improved. This includes manifests that use the puppetlabs-stdlib `deprecation` function or the pseudo keywords `break`, `return`, and `next`. [PUP-10170](https://tickets.puppetlabs.com/browse/PUP-10170)

Add Comment