Jira (PUP-10149) Systemd provider daemon-reload broken in puppet 6.11.0

34 views
Skip to first unread message

Alexander Fisher (JIRA)

unread,
Nov 19, 2019, 6:39:04 PM11/19/19
to puppe...@googlegroups.com
Alexander Fisher created an issue
 
Puppet / Bug PUP-10149
Systemd provider daemon-reload broken in puppet 6.11.0
Issue Type: Bug Bug
Affects Versions: PUP 6.11.0
Assignee: Alexander Fisher
Created: 2019/11/19 3:38 PM
Priority: Normal Normal
Reporter: Alexander Fisher

Puppet Version: 6.11.0
Puppet Server Version: NA
OS Name/Version: RHEL7

The feature implemented in https://tickets.puppetlabs.com/browse/PUP-3483 where daemon-reload is called if required has been broken in puppet 6.11

My PR https://github.com/voxpupuli/puppet-prometheus/pull/390 worked yesterday, but today puppet 6.11 came out and now the build fails.

This change https://github.com/puppetlabs/puppet/commit/0ea1776b096b379b554b835ab091ec00d325e99c#diff-dafbe8211057bc10ff2cfe788a6c4ebbR130 looks to be the problem.

With the `-` added where it has been, the `-property=NeedDaemonReload` argument is not processes and all properties are returned
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Josh Cooper (JIRA)

unread,
Nov 19, 2019, 7:08:03 PM11/19/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Night's Watch

Alexander Fisher (JIRA)

unread,
Nov 20, 2019, 6:48:05 AM11/20/19
to puppe...@googlegroups.com
Alexander Fisher updated an issue
Change By: Alexander Fisher
*Puppet Version:* 6.11.0
*Puppet Server Version:* NA
*OS Name/Version:* RHEL7


The feature implemented in https://tickets.puppetlabs.com/browse/PUP-3483 where daemon-reload is called if required has been broken in puppet 6.11

My PR https://github.com/voxpupuli/puppet-prometheus/pull/390 worked yesterday, but today puppet 6.11 came out and now the build fails.

This change https://github.com/puppetlabs/puppet/commit/0ea1776b096b379b554b835ab091ec00d325e99c#diff-dafbe8211057bc10ff2cfe788a6c4ebbR130 looks to be the problem.

With the ` {noformat}' -- ` '{noformat} added where it has been, the ` {noformat}' --property=NeedDaemonReload ` '{noformat} argument is not processes processed (as an option) and all properties are returned .

Josh Cooper (JIRA)

unread,
Nov 20, 2019, 1:19:04 PM11/20/19
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-10149
 
Re: Systemd provider daemon-reload broken in puppet 6.11.0

This was merged to 6.4.x in dcf164e46c and 6.11.1_release in 248073cba5

Josh Cooper (JIRA)

unread,
Nov 20, 2019, 2:07:03 PM11/20/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Change By: Josh Cooper
Fix Version/s: PUP 6.11.1

Ciprian Badescu (JIRA)

unread,
Nov 20, 2019, 2:09:05 PM11/20/19
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
Change By: Ciprian Badescu
Release Notes: Bug Fix

Ciprian Badescu (JIRA)

unread,
Nov 20, 2019, 2:14:04 PM11/20/19
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
Change By: Ciprian Badescu
Release Notes Summary: fix regression of systemd provider daemon-reload operation

Heston Hoffman (JIRA)

unread,
Nov 20, 2019, 3:54:04 PM11/20/19
to puppe...@googlegroups.com
Heston Hoffman updated an issue
Change By: Heston Hoffman
Labels: resolved-issue-added

Heston Hoffman (JIRA)

unread,
Nov 21, 2019, 12:50:04 PM11/21/19
to puppe...@googlegroups.com

Josh Cooper (JIRA)

unread,
Nov 25, 2019, 4:44:08 PM11/25/19
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-10149

Passed CI in 6.11.1: 98a3022c85 and master: c89b3235935ec99ee5397c7691403361fc69167e

Dorin Pleava (JIRA)

unread,
Jan 8, 2020, 9:53:03 AM1/8/20
to puppe...@googlegroups.com
Dorin Pleava updated an issue
 
Change By: Dorin Pleava
Fix Version/s: PUP 6.4.5
Reply all
Reply to author
Forward
0 new messages