Jira (PUP-10137) HTTP Retry after 408 request timeout or 504 gateway timeout

[Josh Cooper (JIRA)]

Josh Cooper created an issue

Puppet / PUP-10137 HTTP Retry after 408 request timeout or 504 gateway timeout Issue Type: Bug Assignee: Unassigned Created: 2019/11/12 12:10 PM Priority: Normal Reporter: Josh Cooper HTTP 408 says the server should close the connection and the client should make a new connection and retry on that. But I don't see any mention of an `Retry-After` header. https://tools.ietf.org/html/rfc7231#section-6.5.7 Similarly HTTP 504 doesn't mention that header. https://tools.ietf.org/html/rfc7231#section-6.6.5 It also looks like `Retry-After` can be included in any 3xx response: https://tools.ietf.org/html/rfc7231#section-7.1.3 Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-10137 HTTP Retry after 408 request timeout or 504 gateway timeout

Change By: Josh Cooper Team: Coremunity

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-10137 HTTP Retry after 408 request timeout or 504 gateway timeout Change By: Josh Cooper

HTTP 408 says the server should close the connection and the client should make a new connection and retry on that. But I don't see any mention of an `Retry-After` header. https://tools.ietf.org/html/rfc7231#section-6.5.7 Similarly HTTP 504 doesn't mention that header. https://tools.ietf.org/html/rfc7231#section-6.6.5

It also looks like `Retry-After` can be included in any 3xx response: https://tools.ietf.org/html/rfc7231#section-7.1.3 but our http code assumes they are exclusive.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10137 HTTP Retry after 408 request timeout or 504 gateway timeout

Change By: Josh Cooper Epic Link: PUP- 8550 9910

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10137

Re: HTTP Retry after 408 request timeout or 504 gateway timeout I moved this to the http file sources epic, because AFAIK puppetserver never uses those HTTP status codes to deal with thundering herds. It's possible some intermediate proxy or load-balancer might, but I think it's more likely that it would happen when retrieving files from third-party HTTP servers.

Add Comment

[Justin Stoller (Jira)]

Justin Stoller commented on PUP-10137

Re: HTTP Retry after 408 request timeout or 504 gateway timeout

Server uses 503 w/ a Retry-After: code, Mozilla's recommendations to deal w/ thundering heards.

Add Comment

[Charlie Sharpsteen (Jira)]

Charlie Sharpsteen commented on PUP-10137

Re: HTTP Retry after 408 request timeout or 504 gateway timeout

I can't think of a Puppet API that currently uses the 408 or 504 status codes. So, this would mostly be fore retrying requests to 3rd party APIs. This would be useful, but I haven't heard any requests for it and it could also be implemented in the logic of a custom function or provider that needed it.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10137

HTTP Retry after 408 request timeout or 504 gateway timeout

Change By: Josh Cooper Acceptance Criteria: The Puppet::HTTP::Client should handle a Retry-After header in any 3xx response, not just 503 & 429. Need more information to see if Retry-After with 408 & 504 makes sense

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10137 HTTP Retry after 408 request timeout or 504 gateway timeout

Change By: Josh Cooper Sprint: Community PRs

Add Comment

[Josh Cooper (Jira)]

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10137

Re: HTTP Retry after 408 request timeout or 504 gateway timeout I'm going to move this out of the epic but leave the ticket open. Might be a good beginner ticket.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10137

HTTP Retry after 408 request timeout or 504 gateway timeout

Change By: Josh Cooper Labels: beginner

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10137 HTTP Retry after 408 request timeout or 504 gateway timeout

Change By: Josh Cooper Epic Link: PUP-9910

Add Comment