Jira (PUP-10123) Static catalogs should check whether a directory is inlineable before collecting metadata for its children

5 views
Skip to first unread message

Josh Cooper (JIRA)

unread,
Nov 7, 2019, 12:52:03 PM11/7/19
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Bug PUP-10123
Static catalogs should check whether a directory is inlineable before collecting metadata for its children
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2019/11/07 9:51 AM
Priority: Normal Normal
Reporter: Josh Cooper

While researching PE-27428 we discovered that the compiler terminus collects metadata for each file resource and then decides whether the metadata can be inlined or not (only files within a module in the per-environment directory). In the case of a recursive file resource, the terminus collects metadata for the directory and its children. See https://github.com/puppetlabs/puppet/blob/d579170b0583eed4e9050a8b798574c451f3c2ac/lib/puppet/indirector/catalog/compiler.rb#L186-L204

PE uses a recursive file resource to provision a replica. The resource is of the form:

file { "/opt/puppetlabs/server/data/packages/public":
  ensure => directory,
  purge => true,
  recurse => true,
  force => true,
  source => ["puppet:///pe_packages"]
}

However, the pe_packages mount point is not inlineable. This means puppetserver does md5/sha256 checksums for all of the puppet-agent packages, only to discard the metadata.

The compiler indirection should collect metadata for the directory first, to resolve the requested path into an absolute path, and then decide whether to collect metadata for its children.

/cc Joshua Partlow, Maggie Dreyer

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Josh Cooper (JIRA)

unread,
Nov 8, 2019, 12:05:03 AM11/8/19
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
May 22, 2020, 3:37:03 PM5/22/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Epic Link: PUP-10533
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages