Jira (PUP-10107) Unvendor pathspec

41 views
Skip to first unread message

Josh Cooper (JIRA)

unread,
Oct 22, 2019, 5:41:03 PM10/22/19
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Task PUP-10107
Unvendor pathspec
Issue Type: Task Task
Assignee: Unassigned
Created: 2019/10/22 2:40 PM
Priority: Normal Normal
Reporter: Josh Cooper

pathspec was vendored in puppet years ago to support puppet module build. That functionality has since been removed, and pathspec is not used in puppet.

In 6.x (this ticket) we should unvendor pathspec and add it as a runtime dependency so as to not break anyone.

In 7.0, remove the runtime dependency.
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Josh Cooper (JIRA)

unread,
Oct 22, 2019, 5:41:03 PM10/22/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Coremunity

Jorie Tappa (JIRA)

unread,
Oct 29, 2019, 2:57:02 PM10/29/19
to puppe...@googlegroups.com
Jorie Tappa assigned an issue to Jorie Tappa
Change By: Jorie Tappa
Assignee: Jorie Tappa

Josh Cooper (JIRA)

unread,
Oct 30, 2019, 2:17:02 AM10/30/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Coremunity Hopper

Josh Cooper (JIRA)

unread,
Oct 30, 2019, 2:38:03 AM10/30/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Attachment: gems.png
Acceptance Criteria: # Add pathspec as a runtime dependency to all of the projects that depend on puppet. See  !gems.png!
# For example, agent-components, pdk-runtime, pe-bolt-server, etc 
# Add pathspec to puppetserver resources/ext/build-scripts/jruby-gem-list.txt
# Add pathspec to puppet's .gemspec
# Add pathspec to puppet's {{gem_runtime_dependencies}} in ext/project_data.yaml
# Run "jenkins please test this with servertests" and make sure it passes.

Josh Cooper (JIRA)

unread,
Nov 18, 2019, 1:11:05 PM11/18/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Coremunity Hopper Platform Core KANBAN

Josh Cooper (JIRA)

unread,
Dec 11, 2019, 2:40:03 PM12/11/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Platform Core KANBAN

Jorie Tappa (JIRA)

unread,
Feb 20, 2020, 1:43:08 PM2/20/20
to puppe...@googlegroups.com
Jorie Tappa assigned an issue to Unassigned
Change By: Jorie Tappa
Assignee: Jorie Tappa

Josh Cooper (Jira)

unread,
May 5, 2020, 12:50:03 PM5/5/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 7.0.0
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Josh Cooper (Jira)

unread,
May 5, 2020, 12:51:05 PM5/5/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Epic Link: PUP-9120

Josh Cooper (Jira)

unread,
Jul 21, 2020, 12:55:03 PM7/21/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Epic Link: PUP- 9120 10592

Rob Braden (Jira)

unread,
Jul 22, 2020, 7:06:02 PM7/22/20
to puppe...@googlegroups.com
Rob Braden updated an issue
Change By: Rob Braden
Labels: platform_7

Josh Cooper (Jira)

unread,
Jul 29, 2020, 3:44:03 PM7/29/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
pathspec was vendored in puppet years ago to support {{puppet module build}}. That functionality has since been removed, and {{pathspec}} is not used in puppet.

 - In 6.x (this ticket) we should unvendor pathspec and add it as a runtime dependency so as to not break anyone. -

In 7.0, remove the runtime dependency.

Josh Cooper (Jira)

unread,
Jul 29, 2020, 3:54:03 PM7/29/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Acceptance Criteria: # Add pathspec as a runtime dependency to all of the projects that depend on puppet . See  !gems.png!

# For example, agent-components, pdk-runtime, pe-bolt-server, etc 
# Add pathspec to puppetserver resources/ext/build-scripts/jruby-gem-list.txt
# Add pathspec to puppet's .gemspec
# Add pathspec to puppet's {{gem_runtime_dependencies}} in ext/project_data.yaml
# Run "jenkins please test this no longer ships with servertests" and make sure it passes. vendored pathspec

Josh Cooper (Jira)

unread,
Jul 29, 2020, 3:54:03 PM7/29/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
pathspec was vendored in puppet years ago to support {{puppet module build}}. That functionality has since been removed, and {{pathspec}} is not used in puppet.

-In 6.x (this ticket) we should unvendor pathspec and add it as a runtime dependency so as to not break anyone.-

In 7.0, remove the runtime dependency vendored pathspec code .

Josh Cooper (Jira)

unread,
Jul 29, 2020, 3:55:03 PM7/29/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Platform Core KANBAN

Josh Cooper (Jira)

unread,
Jul 29, 2020, 3:55:03 PM7/29/20
to puppe...@googlegroups.com
Josh Cooper assigned an issue to Josh Cooper
Change By: Josh Cooper
Assignee: Josh Cooper

Josh Cooper (Jira)

unread,
Jul 29, 2020, 4:17:03 PM7/29/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Epic Link: PUP- 10592 9120

Josh Cooper (Jira)

unread,
Jul 30, 2020, 12:26:03 PM7/30/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jul 30, 2020, 12:30:03 PM7/30/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Release Notes: Bug Fix
Release Notes Summary: The pathspec ruby library is no longer vendored in puppet. Install the pathspec rubygem if this functionality is required.

Josh Cooper (Jira)

unread,
Aug 5, 2020, 12:45:03 PM8/5/20
to puppe...@googlegroups.com
Josh Cooper commented on Task PUP-10107
 
Re: Unvendor pathspec

Passed CI in 81e3bdf38bbfb1ec

Claire Cadman (Jira)

unread,
Nov 10, 2020, 5:01:03 AM11/10/20
to puppe...@googlegroups.com
Claire Cadman updated an issue
Change By: Claire Cadman
Labels: doc_reviewed platform_7
Reply all
Reply to author
Forward
0 new messages