Jira (PUP-10052) Move indirector global config setting out of the default hooks

4 views
Skip to first unread message

Tony Vu (JIRA)

unread,
Sep 26, 2019, 12:22:02 PM9/26/19
to puppe...@googlegroups.com
Tony Vu created an issue
 
Puppet / Bug PUP-10052
Move indirector global config setting out of the default hooks
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2019/09/26 9:21 AM
Priority: Normal Normal
Reporter: Tony Vu

The `storeconfigs` hook currently contains the code to set indirector settings globally; this has the side affect of being run every time the setting is set/hook is called. This doesn't have any real detrimental behavior for single threaded behavior, but it will be undesirable for multithreaded execution.

Instead of running in the hook, it should run during setting initialization, probably somewhere during `Puppet.initialize_settings`.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Justin Stoller (JIRA)

unread,
Jan 28, 2020, 7:29:04 PM1/28/20
to puppe...@googlegroups.com
Justin Stoller commented on Bug PUP-10052
 
Re: Move indirector global config setting out of the default hooks

After this ticket was created we audited the settings for threadsafety and the storeconfigs setting is not one we have found any uses of setting at runtime. It therefore didn't go into our general threadsafe settings work (unlike tasks, strict, strict_variables...).

As such, when the hook is currently called (during initialization) is fine even in a multithreaded environment and re-setting this to another value during runtime (eg catalog compilation) won't be supported, consequently the fact that the hook isn't threadsafe shouldn't be a problem.

Reply all
Reply to author
Forward
0 new messages