Jira (PUP-9995) Examine thread safety for additional indirector variables

7 views
Skip to first unread message

Tony Vu (JIRA)

unread,
Sep 3, 2019, 1:58:03 PM9/3/19
to puppe...@googlegroups.com
Tony Vu created an issue
 
Puppet / Task PUP-9995
Examine thread safety for additional indirector variables
Issue Type: Task Task
Assignee: Unassigned
Created: 2019/09/03 10:57 AM
Priority: Normal Normal
Reporter: Tony Vu

Some of the indirector's variables initialized have been made thread-safe in PUP-9933, but there are other variables/accessors that can change. This ticket is to determine if those variables should be also be made threadsafe. They include the name, model, ttl, and @@indirections.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Tony Vu (JIRA)

unread,
Dec 10, 2019, 8:08:03 PM12/10/19
to puppe...@googlegroups.com

Tony Vu (JIRA)

unread,
Dec 20, 2019, 6:33:03 PM12/20/19
to puppe...@googlegroups.com
Tony Vu commented on Task PUP-9995
 
Re: Examine thread safety for additional indirector variables

Closing this out as won't do.

I think ttl is the only potential issue here; if a function were to change the ttl with code similar to Puppet[:runinterval] = 3m that change would only be seen in that thread, whereas previously puppet would have seen that as a global change for all compilations. However, I've only seen examples of code where it is suggested that we read in Puppet settings in that manner, and I don't think actually changing puppet settings during manifest compilation is a pattern we need to support.

I think a more common approach would be to hook into the puppet.conf and set the runinterval there, which would prompt a restart of the agent.

Reply all
Reply to author
Forward
0 new messages